Change the value of AminoMsg to the general type #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tranvanthai
force-pushed
the
feature/sample-staking-tx
branch
from
35e6315
to
48f277a
Compare
tranvanthai
force-pushed
the
feature/sample-staking-tx
branch
from
48f277a
to
41dd43d
Compare
4 tasks
jaeseung-bae
reviewed
Jul 7, 2023
examples/multisig-example/src/main/kotlin/network/finschia/sdk/example/Client.kt
Show resolved
Hide resolved
|
@tranvanthai |
jaeseung-bae
approved these changes
Jul 10, 2023
loin3
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the value of AminoMsg to the general type
Description
Currently, the AminoMsg is only supported the MsgSend, It's hard to use the tx module. Thus, I change the value of AminoMsg to JsonElement. It's easy to implement with other messages: MsgDelegate, MsgUnDelegate.....
Motivation and context
It's hard to use the AminoMsg for other messages, I improve it to use with all messages.
How has this been tested?
I add the testing code in the examples/multisig-example. Please use it to test by yourself.
Screenshots (if appropriate):
Checklist:
CHANGELOG.md.