Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add examples for sigle-sig, multi-sig #21

Merged
merged 10 commits into from
Jul 20, 2023
Merged

feat: add examples for sigle-sig, multi-sig #21

merged 10 commits into from
Jul 20, 2023

Conversation

jaeseung-bae
Copy link
Contributor

@jaeseung-bae jaeseung-bae commented Jul 13, 2023 •
edited

Description

  • add createValidator examples for single and multi-sig
  • add MsgCreateValidator message
  • add util(protoDecimalToJson and vice verse)

Motivation and context

  • Requested for some examples

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I have added a relevant changelog to CHANGELOG.md.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@jaeseung-bae jaeseung-bae force-pushed the feat/add-multi-sig-example branch 2 times, most recently from 5bb2f3b to a538c0f Compare July 13, 2023 08:51
@jaeseung-bae jaeseung-bae changed the title Feat/add multi sig example Feat/add examples for sigle-sig, multi-sig Jul 13, 2023
@jaeseung-bae jaeseung-bae marked this pull request as ready for review July 13, 2023 09:25
@jaeseung-bae jaeseung-bae self-assigned this Jul 14, 2023
@loin3 loin3 self-requested a review July 19, 2023 07:12
zemyblue
zemyblue reviewed Jul 19, 2023
View reviewed changes
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the title to feat: ~~~.

@jaeseung-bae jaeseung-bae changed the title Feat/add examples for sigle-sig, multi-sig feat: add examples for sigle-sig, multi-sig Jul 19, 2023
@jaeseung-bae jaeseung-bae merged commit 4a5cc0c into main Jul 20, 2023
4 checks passed
@jaeseung-bae jaeseung-bae deleted the feat/add-multi-sig-example branch July 20, 2023 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zemyblue zemyblue zemyblue approved these changes

@loin3 loin3 loin3 approved these changes

@0Tech 0Tech Awaiting requested review from 0Tech

@dudong2 dudong2 Awaiting requested review from dudong2

Assignees

@jaeseung-bae jaeseung-bae

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jaeseung-bae @zemyblue @loin3