Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unable to connect ledger nano S on Ubuntu #1040

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

jaeseung-bae
Copy link
Contributor

@jaeseung-bae jaeseung-bae commented Jul 12, 2023

Description

closes: #1039

  • The latest version for github.com/cosmos/ledger-cosmos-go is v0.13.0. The latest version breaks some interfaces so I bump up with v0.12.2(the second latest one) which is enough to fix the issue.

Motivation and context

How has this been tested?

  • I tested with a nano S plus ledger on both Ubuntu 20.04 and Mac

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@jaeseung-bae jaeseung-bae changed the title fix: unable to connect ledger nano S on Ubuntu20.04, 22.04 by bump up… fix: unable to connect ledger nano S on Ubuntu20.04, 22.04 Jul 12, 2023
@jaeseung-bae jaeseung-bae self-assigned this Jul 12, 2023
@jaeseung-bae jaeseung-bae marked this pull request as ready for review July 12, 2023 10:06
@jaeseung-bae jaeseung-bae changed the title fix: unable to connect ledger nano S on Ubuntu20.04, 22.04 fix: unable to connect ledger nano S on Ubuntu Jul 12, 2023
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is duplicated with #1027 .
The #1027 PR bumps up ledger-cosmos-go to v0.13.0

What shall we do in order to use ledger-cosmos-go v0.13.0?

@jaeseung-bae
Copy link
Contributor Author

jaeseung-bae commented Jul 14, 2023

I think this PR is duplicated with #1027 . The #1027 PR bumps up ledger-cosmos-go to v0.13.0

What shall we do in order to use ledger-cosmos-go v0.13.0?

From v0.13.0, interface SECP256K1's SignSECP256K1 function has changed.
v0.13.0 introduces feat!: Add SIGN_MODE_TEXTUAL
In order to use v0.13.0, some of code that use SignSECP256K1() must be changed for compile.

SECP256K1 interface {
		SignSECP256K1([]uint32, []byte) ([]byte, error) // v0.12.2
		SignSECP256K1([]uint32, []byte, byte) ([]byte, error) // v0.13.0
}

@jaeseung-bae
Copy link
Contributor Author

jaeseung-bae commented Jul 14, 2023

@zemyblue, Do you think It is better to change the code to adapt v0.13.0 from PR #1027.

@zemyblue
Copy link
Member

@zemyblue, Do you think It is better to change the code to adapt v0.13.0 from PR #1027.

Yes, but I think we cannot use v0.13.0 in this case.
I want to know why v0.13.0 can't.

@jaeseung-bae jaeseung-bae merged commit 3e775ff into Finschia:main Jul 20, 2023
32 checks passed
@jaeseung-bae jaeseung-bae deleted the fix/ledger-ubuntu branch July 20, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"failed to retrieve device: ledger nano S: no ledger connected" on ubuntu 20.04, 22.04
3 participants