Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make x/foundation MsgExec propagate events #1053

Merged
merged 3 commits into from
Jul 25, 2023
Merged

fix: make x/foundation MsgExec propagate events #1053

merged 3 commits into from
Jul 25, 2023

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Jul 20, 2023 •
edited
Loading

Description

closes: #1052

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech added A: bug Something isn't working C:x/foundation x/foundation module labels Jul 20, 2023
@0Tech 0Tech self-assigned this Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023 •
edited
Loading

Codecov Report

Merging #1053 (57179f9) into main (3e775ff) will decrease coverage by 0.01%.
The diff coverage is 60.00%.

❗ Current head 57179f9 differs from pull request most recent head 6a87d12. Consider uploading reports for the commit 6a87d12 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1053      +/-   ##
==========================================
- Coverage   62.01%   62.00%   -0.01%     
==========================================
  Files         656      656              
  Lines       78937    78938       +1     
==========================================
- Hits        48949    48947       -2     
- Misses      27299    27301       +2     
- Partials     2689     2690       +1
Impacted Files Coverage Δ
x/foundation/keeper/internal/exec.go 89.61% <60.00%> (-3.82%) ⬇️

@0Tech 0Tech marked this pull request as ready for review July 20, 2023 10:05
@0Tech 0Tech merged commit f8840ed into Finschia:main Jul 25, 2023
32 checks passed
@0Tech 0Tech deleted the events branch July 25, 2023 07:46
0Tech added a commit to 0Tech/finschia-sdk that referenced this pull request Jul 31, 2023
@0Tech
fix: make x/foundation MsgExec propagate events (Finschia#1053)
7fa65ca 
* Fix and update tests

* Update CHANGELOG.md

* Revert irrelevant changes
@0Tech 0Tech mentioned this pull request Aug 1, 2023
Merged
4 tasks
0Tech added a commit to 0Tech/finschia-sdk that referenced this pull request Aug 1, 2023
@0Tech
fix: make x/foundation MsgExec propagate events (Finschia#1053)
3867111 
* Fix and update tests

* Update CHANGELOG.md

* Revert irrelevant changes
0Tech added a commit that referenced this pull request Aug 8, 2023
@0Tech
fix: make x/foundation MsgExec propagate events (backport #1053) (#1061)
2b7b38e 
* fix: make x/foundation MsgExec propagate events (#1053)

* Fix and update tests

* Update CHANGELOG.md

* Revert irrelevant changes

* Update CHANGELOG.md
@zemyblue zemyblue mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zemyblue zemyblue zemyblue approved these changes

@loin3 loin3 loin3 approved these changes

@dudong2 dudong2 Awaiting requested review from dudong2

@jaeseung-bae jaeseung-bae Awaiting requested review from jaeseung-bae jaeseung-bae is a code owner

Assignees

@0Tech 0Tech

Labels
A: bug Something isn't working C:x/foundation x/foundation module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x/foundation MsgExec must propagate its events inside
3 participants
@0Tech @zemyblue @loin3