Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve baseapp event emission (backport cosmos/cosmos-sdk#14356) #1075

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Aug 10, 2023

Description

ref: #1076

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech self-assigned this Aug 10, 2023
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ 0Tech
❌ julienrbrt
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #1075 (efa76da) into release/v0.47.x (92d75cf) will increase coverage by 0.10%.
Report is 3 commits behind head on release/v0.47.x.
The diff coverage is 89.47%.

❗ Current head efa76da differs from pull request most recent head 0161660. Consider uploading reports for the commit 0161660 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v0.47.x    #1075      +/-   ##
===================================================
+ Coverage            62.04%   62.14%   +0.10%     
===================================================
  Files                  655      655              
  Lines                78983    78876     -107     
===================================================
+ Hits                 49004    49021      +17     
+ Misses               27293    27169     -124     
  Partials              2686     2686              
Files Changed Coverage Δ
x/auth/vesting/msg_server.go 67.27% <ø> (-3.70%) ⬇️
x/bank/keeper/msg_server.go 3.84% <ø> (+0.81%) ⬆️
x/bank/types/events.go 0.00% <ø> (ø)
x/crisis/keeper/msg_server.go 0.00% <ø> (ø)
x/distribution/keeper/msg_server.go 2.66% <ø> (+0.77%) ⬆️
x/evidence/keeper/msg_server.go 16.66% <ø> (+6.66%) ⬆️
x/gov/keeper/msg_server.go 2.24% <0.00%> (+0.59%) ⬆️
x/slashing/keeper/msg_server.go 14.28% <ø> (+5.19%) ⬆️
x/staking/keeper/msg_server.go 0.74% <ø> (+0.06%) ⬆️
baseapp/baseapp.go 79.13% <100.00%> (+0.46%) ⬆️
... and 2 more

... and 2 files with indirect coverage changes

@0Tech 0Tech marked this pull request as ready for review August 10, 2023 07:06
@0Tech 0Tech merged commit eed9bb8 into Finschia:release/v0.47.x Aug 10, 2023
28 of 29 checks passed
@0Tech 0Tech deleted the improve-event branch August 10, 2023 11:01
@zemyblue zemyblue added this to the v0.47.3 milestone Aug 16, 2023
0Tech added a commit to 0Tech/finschia-sdk that referenced this pull request Aug 24, 2023
Finschia#1075)

* fix: improve baseapp event emission (#14356)

* Update CHANGELOG.md

---------

Co-authored-by: Julien Robert <julien@rbrt.fr>
0Tech added a commit that referenced this pull request Aug 24, 2023
* fix: improve baseapp event emission (backport cosmos/cosmos-sdk#14356) (#1075)

* fix: improve baseapp event emission (#14356)

* Update CHANGELOG.md

---------

Co-authored-by: Julien Robert <julien@rbrt.fr>

* Update CHANGELOG.md

---------

Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants