Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not add module attribute in case of ibc messages #1079

Merged
merged 4 commits into from
Aug 17, 2023
Merged

fix: do not add module attribute in case of ibc messages #1079

merged 4 commits into from
Aug 17, 2023

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Aug 10, 2023 •
edited
Loading

Description

closes: #1076

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech added the A: bug Something isn't working label Aug 10, 2023
@0Tech 0Tech self-assigned this Aug 10, 2023
@0Tech 0Tech changed the title fix: do not add module attribute in case of ibc fix: do not add module attribute in case of ibc messages Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023 •
edited
Loading

Codecov Report

Merging #1079 (0f501d8) into release/v0.47.x (92d75cf) will increase coverage by 0.10%.
Report is 4 commits behind head on release/v0.47.x.
The diff coverage is 90.00%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v0.47.x    #1079      +/-   ##
===================================================
+ Coverage            62.04%   62.14%   +0.10%     
===================================================
  Files                  655      655              
  Lines                78983    78878     -105     
===================================================
+ Hits                 49004    49022      +18     
+ Misses               27293    27170     -123     
  Partials              2686     2686
Files Changed Coverage Δ
x/auth/vesting/msg_server.go 67.27% <ø> (-3.70%) ⬇️
x/bank/keeper/msg_server.go 3.84% <ø> (+0.81%) ⬆️
x/bank/types/events.go 0.00% <ø> (ø)
x/crisis/keeper/msg_server.go 0.00% <ø> (ø)
x/distribution/keeper/msg_server.go 2.66% <ø> (+0.77%) ⬆️
x/evidence/keeper/msg_server.go 16.66% <ø> (+6.66%) ⬆️
x/gov/keeper/msg_server.go 2.24% <0.00%> (+0.59%) ⬆️
x/slashing/keeper/msg_server.go 14.28% <ø> (+5.19%) ⬆️
x/staking/keeper/msg_server.go 0.74% <ø> (+0.06%) ⬆️
baseapp/baseapp.go 79.22% <100.00%> (+0.55%) ⬆️
... and 2 more

... and 1 file with indirect coverage changes

@0Tech 0Tech marked this pull request as ready for review August 10, 2023 13:41
jaeseung-bae
jaeseung-bae previously approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@jaeseung-bae jaeseung-bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zemyblue zemyblue added this to the v0.47.3 milestone Aug 16, 2023
0Tech
0Tech commented Aug 16, 2023
View reviewed changes
Copy link
Collaborator Author

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the message name.

baseapp/baseapp_test.go Outdated Show resolved Hide resolved
baseapp/baseapp_test.go Outdated Show resolved Hide resolved
@0Tech 0Tech merged commit daaa86c into Finschia:release/v0.47.x Aug 17, 2023
29 checks passed
@0Tech 0Tech deleted the ignore-ibc branch August 17, 2023 00:11
@0Tech 0Tech mentioned this pull request Aug 17, 2023
Merged
4 tasks
0Tech added a commit to 0Tech/finschia-sdk that referenced this pull request Aug 24, 2023
@0Tech
fix: do not add module attribute in case of ibc messages (Finschia#…
051b484 
…1079)

* Do not add `module` attribute in case of ibc

* Update CHANGELOG.md

* Add test

* Apply suggestions from code review
@0Tech 0Tech mentioned this pull request Aug 24, 2023
Merged
5 tasks
0Tech added a commit that referenced this pull request Aug 24, 2023
@0Tech
fix: do not add module attribute in case of ibc messages (backport #…
c057de9 
…1079) (#1092)

* fix: do not add `module` attribute in case of ibc messages (#1079)

* Do not add `module` attribute in case of ibc

* Update CHANGELOG.md

* Add test

* Apply suggestions from code review

* Update CHANGELOG.md
@zemyblue zemyblue mentioned this pull request Sep 8, 2023
Merged
@0Tech 0Tech mentioned this pull request Dec 22, 2023
Open
96 tasks
@jaeseung-bae jaeseung-bae mentioned this pull request Jan 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zemyblue zemyblue zemyblue approved these changes

@jaeseung-bae jaeseung-bae jaeseung-bae approved these changes

Assignees

@0Tech 0Tech

Labels
A: bug Something isn't working
Projects
None yet
Milestone
v0.47.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0Tech @zemyblue @jaeseung-bae