Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add detailed explanation about default events #1083

Merged

Conversation

ryu1-sakai
Copy link
Contributor

@ryu1-sakai ryu1-sakai commented Aug 17, 2023

Description

It seems better to add more detailed information about default events emitted by baseapp. (Especially information about the event structure.)

This PR is trying to add such information to the document created by #1081.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@CLAassistant
Copy link

CLAassistant commented Aug 17, 2023

CLA assistant check
All committers have signed the CLA.

@zemyblue zemyblue added the documentation Improvements or additions to documentation label Aug 28, 2023
@zemyblue zemyblue added this to the v0.47.3 milestone Aug 31, 2023
docs/docs/core/08-events.md Outdated Show resolved Hide resolved
@zemyblue zemyblue assigned zemyblue and unassigned 0Tech Sep 8, 2023
@zemyblue zemyblue removed this from the v0.47.3 milestone Sep 8, 2023
@ryu1-sakai
Copy link
Contributor Author

@zemyblue, PTAL

Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryu1-sakai , please resolve conflicts

@ryu1-sakai
Copy link
Contributor Author

@zemyblue Rebased.

@zemyblue zemyblue requested a review from 0Tech September 14, 2023 01:52
@tkxkd0159 tkxkd0159 self-requested a review September 19, 2023 01:18
@zemyblue zemyblue merged commit 8ae897c into Finschia:release/v0.47.x Sep 20, 2023
24 checks passed
zemyblue pushed a commit to zemyblue/finschia-sdk that referenced this pull request Oct 17, 2023
* docs: add detailed explanation about default events

* Update CHANGELOG.md

* improve redundant sentences

(cherry picked from commit 8ae897c)

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants