Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(collection): refactor overall unittests of x/collection #1139

Merged
merged 7 commits into from
Oct 16, 2023

Conversation

tkxkd0159
Copy link
Member

@tkxkd0159 tkxkd0159 commented Oct 13, 2023

Description

closes: #XXXX

  • remove deterministic flag. Only test with random addresses, but events can be generated by those value
  • remove all helper functions for generating a event
  • add some global test helper functions to reduce repetition
  • add more test for MsgOperatorBurnFT

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@tkxkd0159 tkxkd0159 self-assigned this Oct 13, 2023
@tkxkd0159 tkxkd0159 changed the title test(collection): enhance unittests test(collection): refactor unittests Oct 13, 2023
@tkxkd0159 tkxkd0159 changed the title test(collection): refactor unittests test(collection): refactor overall unittests of x/collection Oct 13, 2023
@tkxkd0159 tkxkd0159 changed the base branch from main to rc/v0.48.0-rcx October 13, 2023 10:32
x/collection/keeper/msg_server_test.go Outdated Show resolved Hide resolved
x/collection/keeper/msg_server_test.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #1139 (f6c0de1) into rc/v0.48.0-rcx (8920362) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           rc/v0.48.0-rcx    #1139   +/-   ##
===============================================
  Coverage           69.77%   69.78%           
===============================================
  Files                 645      646    +1     
  Lines               67482    67489    +7     
===============================================
+ Hits                47086    47094    +8     
+ Misses              18210    18209    -1     
  Partials             2186     2186           
Files Coverage Δ
testutil/encoding.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@tkxkd0159 tkxkd0159 merged commit 08a4586 into rc/v0.48.0-rcx Oct 16, 2023
37 checks passed
@tkxkd0159 tkxkd0159 deleted the tkxkd0159/add-collection-test branch October 16, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants