Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(token): refactoring testcase for token #1140

Merged
merged 5 commits into from
Oct 17, 2023

Conversation

jaeseung-bae
Copy link
Contributor

@jaeseung-bae jaeseung-bae commented Oct 16, 2023

Description

  • Just refactoring testcases for token module

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@jaeseung-bae jaeseung-bae changed the title Test/token test: refactoring testcase for token Oct 16, 2023
@jaeseung-bae jaeseung-bae changed the title test: refactoring testcase for token test(token): refactoring testcase for token Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #1140 (de0c826) into rc/v0.48.0-rcx (08a4586) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           rc/v0.48.0-rcx    #1140   +/-   ##
===============================================
  Coverage           69.77%   69.78%           
===============================================
  Files                 646      646           
  Lines               67489    67493    +4     
===============================================
+ Hits                47093    47098    +5     
+ Misses              18210    18209    -1     
  Partials             2186     2186           
Files Coverage Δ
testutil/encoding.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@jaeseung-bae jaeseung-bae marked this pull request as ready for review October 16, 2023 05:46
zemyblue
zemyblue previously approved these changes Oct 16, 2023
testutil/encoding.go Outdated Show resolved Hide resolved
Co-authored-by: Jayden Lee <41176085+tkxkd0159@users.noreply.github.com>
Copy link
Member

@tkxkd0159 tkxkd0159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeseung-bae jaeseung-bae merged commit ca32838 into Finschia:rc/v0.48.0-rcx Oct 17, 2023
37 checks passed
@jaeseung-bae jaeseung-bae deleted the test/token branch October 17, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants