Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement fetch jwk #1240

Merged
merged 9 commits into from
Feb 20, 2024
Merged

Conversation

shiki-tak
Copy link
Contributor

Description

closes: #XXXX

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@shiki-tak shiki-tak self-assigned this Feb 14, 2024
@shiki-tak shiki-tak marked this pull request as draft February 14, 2024 06:56
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 58 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (feat/zkauth@1132e10). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             feat/zkauth    #1240   +/-   ##
==============================================
  Coverage               ?   69.74%           
==============================================
  Files                  ?      654           
  Lines                  ?    67761           
  Branches               ?        0           
==============================================
  Hits                   ?    47260           
  Misses                 ?    18294           
  Partials               ?     2207           
Files Coverage Δ
x/zkauth/testutil/keeper.go 100.00% <ø> (ø)
x/zkauth/types/codec.go 70.58% <80.00%> (ø)
x/zkauth/types/config.go 0.00% <0.00%> (ø)
x/zkauth/types/msgs.go 0.00% <0.00%> (ø)
x/zkauth/keeper/keeper.go 59.15% <54.68%> (ø)

@shiki-tak shiki-tak closed this Feb 16, 2024
@shiki-tak shiki-tak reopened this Feb 16, 2024
@mergify mergify bot mentioned this pull request Feb 16, 2024
5 tasks
Copy link

sonarcloud bot commented Feb 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
18.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@shiki-tak shiki-tak requested review from Mdaiki0730 and kokeshiM0chi and removed request for 0Tech, tkxkd0159 and jaeseung-bae February 19, 2024 02:03
@shiki-tak shiki-tak marked this pull request as ready for review February 19, 2024 02:30
x/zkauth/keeper/keeper_test.go Outdated Show resolved Hide resolved
x/zkauth/keeper/keeper_test.go Outdated Show resolved Hide resolved
x/zkauth/keeper/keeper_test.go Outdated Show resolved Hide resolved
x/zkauth/keeper/keeper_test.go Outdated Show resolved Hide resolved
x/zkauth/keeper/keeper.go Outdated Show resolved Hide resolved
x/zkauth/keeper/keeper.go Outdated Show resolved Hide resolved
x/zkauth/keeper/keeper.go Outdated Show resolved Hide resolved
Copy link
Member

@Mdaiki0730 Mdaiki0730 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shiki-tak shiki-tak merged commit 9acaddc into Finschia:feat/zkauth Feb 20, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants