Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduct gas fee from zkauth address #1279

Merged
merged 4 commits into from
Mar 18, 2024
Merged

Conversation

Mdaiki0730
Copy link
Member

@Mdaiki0730 Mdaiki0730 commented Mar 14, 2024

Description

Deduct the gas fee that would have been deducted by DeductFeeDecorator from zkauth address
Mostly the same as DeductFeeDecorator.AnteHandle.

func (dfd DeductFeeDecorator) AnteHandle(ctx sdk.Context, tx sdk.Tx, simulate bool, next sdk.AnteHandler) (newCtx sdk.Context, err error) {

In the future there should be a way to branch out with zkauth more generally.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@Mdaiki0730 Mdaiki0730 changed the title Deduct gas fee Deduct gas fee from zkauth address Mar 14, 2024
@Mdaiki0730 Mdaiki0730 self-assigned this Mar 14, 2024
@Mdaiki0730 Mdaiki0730 marked this pull request as ready for review March 14, 2024 10:53
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 52.94118% with 24 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (feat/zkauth@995ea48). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             feat/zkauth    #1279   +/-   ##
==============================================
  Coverage               ?   69.56%           
==============================================
  Files                  ?      659           
  Lines                  ?    68380           
  Branches               ?        0           
==============================================
  Hits                   ?    47571           
  Misses                 ?    18554           
  Partials               ?     2255           
Files Coverage Δ
x/zkauth/testutil/keeper.go 55.38% <100.00%> (ø)
x/zkauth/ante/zkauth.go 50.00% <50.00%> (ø)

Copy link
Contributor

@shiki-tak shiki-tak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add CHANGELOG

x/zkauth/ante/zkauth.go Show resolved Hide resolved
x/zkauth/ante/zkauth.go Show resolved Hide resolved
shiki-tak
shiki-tak previously approved these changes Mar 15, 2024
zemyblue
zemyblue previously approved these changes Mar 18, 2024
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I agree this pr is good. but we need to check the case that the messages are added multiple and mixing message type. So please add another issue for solving multiple messages.

@Mdaiki0730
Copy link
Member Author

So please add another issue for solving multiple messages.

I added an issue, so I'll merge this PR. Thank you.
#1286

@Mdaiki0730 Mdaiki0730 merged commit 0b5b207 into feat/zkauth Mar 18, 2024
30 checks passed
@Mdaiki0730 Mdaiki0730 deleted the feat/deduct-gas-fee branch March 18, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants