-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduct gas fee from zkauth address #1279
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/zkauth #1279 +/- ##
==============================================
Coverage ? 69.56%
==============================================
Files ? 659
Lines ? 68380
Branches ? 0
==============================================
Hits ? 47571
Misses ? 18554
Partials ? 2255
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add CHANGELOG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I agree this pr is good. but we need to check the case that the messages are added multiple and mixing message type. So please add another issue for solving multiple messages.
I added an issue, so I'll merge this PR. Thank you. |
Description
Deduct the gas fee that would have been deducted by DeductFeeDecorator from zkauth address
Mostly the same as DeductFeeDecorator.AnteHandle.
finschia-sdk/x/auth/ante/fee.go
Line 75 in df06ee1
In the future there should be a way to branch out with zkauth more generally.
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml