Compare the signer of the normal message and the signer of MsgExcute #1291
+89
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Mdaiki0730
requested review from
tkxkd0159,
zemyblue,
0Tech and
jaeseung-bae
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/zkauth #1291 +/- ##
==============================================
Coverage ? 69.57%
==============================================
Files ? 659
Lines ? 68385
Branches ? 0
==============================================
Hits ? 47577
Misses ? 18553
Partials ? 2255
|
ulbqb
reviewed
Mar 22, 2024
ulbqb
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, msgs signer validation is not performed when dispatching msgs of MsgExcute.
This leads to serious problems such as fraudulent transfers.
This can be prevented by making sure that the signer of the msg executed when dispatching msg is the signer of MsgExcute.
We will have to discuss later whether this modification is sufficient.
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml