Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prometheus metrics for caches reverting telemetry metrics #184

Merged
merged 1 commit into from
May 11, 2021

Conversation

egonspace
Copy link

Description

We found that telemetry has serious performance-degradation problem. (1000 tps -> 600 tps on a single node)
This PR reverts telemetry feature and adds prometheus metrics for caches.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@egonspace egonspace self-assigned this May 11, 2021
@egonspace egonspace added this to the performance improvement milestone May 11, 2021
@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #184 (83aa427) into v2/develop (1f739c5) will decrease coverage by 31.55%.
The diff coverage is 72.28%.

Impacted file tree graph

@@               Coverage Diff               @@
##           v2/develop     #184       +/-   ##
===============================================
- Coverage       54.99%   23.44%   -31.56%     
===============================================
  Files             812      765       -47     
  Lines           51487   125253    +73766     
===============================================
+ Hits            28317    29362     +1045     
- Misses          20211    92040    +71829     
- Partials         2959     3851      +892     
Impacted Files Coverage Δ
client/grpc/tmservice/query.pb.go 32.27% <ø> (ø)
client/grpc/tmservice/query.pb.gw.go 30.06% <ø> (ø)
client/keys/root.go 100.00% <ø> (ø)
client/keys/utils.go 44.11% <ø> (+5.22%) ⬆️
crypto/armor.go 85.89% <ø> (ø)
crypto/keys/ed25519/ed25519.go 67.34% <ø> (ø)
crypto/keys/multisig/codec.go 100.00% <ø> (ø)
crypto/keys/secp256k1/secp256k1.go 86.79% <ø> (ø)
server/config/toml.go 18.18% <ø> (ø)
simapp/test_helpers.go 8.41% <0.00%> (+7.91%) ⬆️
... and 201 more

@egonspace egonspace merged commit f9c3e64 into v2/develop May 11, 2021
@egonspace egonspace deleted the egon/v2/chore/revert_telemetry branch May 11, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants