chore: param store doesn't use gas kv #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v2/develop #202 +/- ##
==============================================
- Coverage 53.51% 53.49% -0.02%
==============================================
Files 653 653
Lines 47384 47376 -8
==============================================
- Hits 25357 25345 -12
- Misses 19171 19177 +6
+ Partials 2856 2854 -2
|
whylee259
reviewed
May 21, 2021
| } | ||
|
|
||
| // Returns a transient store for modification | ||
| func (s *Subspace) transientStore(ctx sdk.Context) sdk.KVStore { |
There was a problem hiding this comment.
As the function transientStore is removed, it seems that the tKey is also unused. we can remove it too. (However, API change has occurred, and consumer's additional action is required.)
whylee259
reviewed
May 21, 2021
types/context.go
Outdated
Comment on lines
232
to
236
| // TransientStore fetches a TransientStore from the MultiStore. | ||
| func (c Context) TransientStore(key StoreKey) KVStore { | ||
| return gaskv.NewStore(c.MultiStore().GetKVStore(key), c.GasMeter(), stypes.TransientGasConfig()) | ||
| } | ||
|
|
There was a problem hiding this comment.
I think removing this function has no direct relevance to this PR. (although it is useless yet.)
There was a problem hiding this comment.
You're right. I will put this back and remove the TransientStore in another PR at once.
added 2 commits
May 21, 2021 18:46
whylee259
approved these changes
May 23, 2021
wetcod
approved these changes
May 24, 2021
9 tasks
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Param store does not use gas store any more.
Modified()function of param store is not used anywhere. So I could removeModified()function andTransientStorefrom param store.closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes