chore: remove MaxGas const #253
Merged
+4
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loloicci
force-pushed
the
loloicci/feat/remove-maxgas
branch
from
6351ea8
to
5c8e5fd
Compare
whylee259
reviewed
Jul 6, 2021
|
|
loloicci
force-pushed
the
loloicci/feat/remove-maxgas
branch
from
5c8e5fd
to
177f0c9
Compare
|
@whylee259 I changed the branch rebasing to. Sorry for using force push. |
whylee259
reviewed
Jul 15, 2021
x/wasm/internal/keeper/relay_test.go
Outdated
| @@ -32,7 +32,7 @@ func TestOnOpenChannel(t *testing.T) { | |||
| }, | |||
| "consume max gas": { | |||
| contractAddr: example.Contract, | |||
| contractGas: MaxGas, | |||
| contractGas: math.MaxUint64 / DefaultGasMultiplier, | |||
There was a problem hiding this comment.
Suggested change
| contractGas: math.MaxUint64 / DefaultGasMultiplier, | |
| contractGas: math.MaxUint64 / types.DefaultGasMultiplier, |
and
math should be also imported.
brew0722
approved these changes
Jul 15, 2021
whylee259
approved these changes
Jul 15, 2021
shiki-tak
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #252
merge original #529 and part of #533
docs/) or specification (x/<module>/spec/) (Not Needed)godoccomments. (Not Needed)Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes