Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(wasm): specify wasm event types #254

Merged
merged 6 commits into from
Jun 29, 2021
Merged

Conversation

brew0722
Copy link
Contributor

Description

closes: #146, CosmWasm/wasmd#440


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@brew0722 brew0722 self-assigned this Jun 23, 2021
@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@1e36431). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #254   +/-   ##
=======================================
  Coverage        ?   53.31%           
=======================================
  Files           ?      639           
  Lines           ?    46954           
  Branches        ?        0           
=======================================
  Hits            ?    25035           
  Misses          ?    19071           
  Partials        ?     2848           

Copy link
Contributor

@whylee259 whylee259 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- Change wasm(AttributesKeySigner) to common(AttributesKeySender)
- Remove duplicated the AttributeKeyContract in EventTypeUpdateContractStatus and EventTypeMessage
@brew0722 brew0722 changed the title refactor: specify wasm event types refactor(wasm): specify wasm event types Jun 24, 2021
@brew0722 brew0722 requested a review from whylee259 June 24, 2021 06:25
Jiyong Ha added 3 commits June 24, 2021 16:42
It will be merged one event when calling StringEvents.Flatten()
no need common event, because it is not executed by msg.
@brew0722 brew0722 requested a review from whylee259 June 24, 2021 09:35
Copy link
Contributor

@whylee259 whylee259 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shiki-tak shiki-tak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brew0722 brew0722 merged commit 3178493 into main Jun 29, 2021
@brew0722 brew0722 deleted the brew0722/specify-wasm-events branch June 29, 2021 04:18
@0Tech 0Tech added the C:WASM label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorganize event log for wasm tx
4 participants