fix: force genOrBroadcastFn even when max-msgs != 0 #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0Tech
force-pushed
the
0Tech/fix/withdraw-all-rewards-null
branch
from
a819a84
to
5785fd0
Compare
0Tech
force-pushed
the
0Tech/fix/withdraw-all-rewards-null
branch
from
975ff3d
to
b342b79
Compare
Codecov Report
@@ Coverage Diff @@
## release/v0.43.x #364 +/- ##
==================================================
Coverage ? 53.17%
==================================================
Files ? 642
Lines ? 67250
Branches ? 0
==================================================
Hits ? 35763
Misses ? 28545
Partials ? 2942 |
|
I think it's a good solution. However, it seems that the target branch should be |
0Tech
force-pushed
the
0Tech/fix/withdraw-all-rewards-null
branch
from
b342b79
to
eed98a2
Compare
dudong2
approved these changes
Nov 1, 2021
|
I have submitted the corresponding PR to cosmos-sdk. I will apply this PR after they respond. |
If cli tx withdraw-all-rewards sends empty tx, the tx would be rejected by validators because it has no msgs. However, the cli sends empty tx only if one sets `--max-msgs=0` which means it does not split the msgs. When you set `max-msgs` with any positive number, the cli does not send any tx, which may confuse you because you cannot get the feedback indicating the address has no delegations. This patch addresses the problem, by forcing genOrBroadcastFn when the number of total msgs generated is zero. It will provide the same user experience with any `max-msgs`.
0Tech
force-pushed
the
0Tech/fix/withdraw-all-rewards-null
branch
from
eed98a2
to
b899dae
Compare
0Tech
changed the title
withdraw-all-rewards when the signer has no delegations
egonspace
force-pushed
the
release/v0.43.x
branch
from
be3591b
to
66ff604
Compare
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If cli tx withdraw-all-rewards sends empty tx, the tx would be
rejected by validators because it has no msgs. However, the cli sends
empty tx only if one sets
--max-msgs=0which means it does not splitthe msgs. When you set
max-msgswith any positive number, the clidoes not send any tx, which may confuse you because you cannot get the
feedback indicating the address has no delegations.
This patch addresses the problem, by forcing genOrBroadcastFn when the
number of total msgs generated is zero. It will provide the same user
experience with any
max-msgs.closes: #363
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes