Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate token module from line/link #416

Merged
merged 68 commits into from
Feb 24, 2022
Merged

feat: Migrate token module from line/link #416

merged 68 commits into from
Feb 24, 2022

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Jan 18, 2022

Description

Migrate token module from line/link.

#412

TODOs (separated PR):

  • Add invariant
  • Add spec

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@0Tech 0Tech added the A: improvement Changes in existing functionality label Jan 18, 2022
@0Tech 0Tech changed the title docs: Update CHANGELOG feat: Migrate token module from line/link Jan 18, 2022
@0Tech 0Tech self-assigned this Jan 18, 2022
CHANGELOG.md Outdated Show resolved Hide resolved

func NewQueryCmdTokenBalance() *cobra.Command {
cmd := &cobra.Command{
Use: "token-balance [class-id] [address]",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's quite common :)

@0Tech
Copy link
Collaborator Author

0Tech commented Feb 16, 2022

I will re-run the tests five times in a row to make sure that there is no test failure caused by x/token.

x/token/class/validation.go Outdated Show resolved Hide resolved
x/token/class/validation.go Outdated Show resolved Hide resolved
@0Tech 0Tech merged commit 4bb7b33 into Finschia:main Feb 24, 2022
@0Tech 0Tech deleted the token branch February 24, 2022 08:36
@zemyblue zemyblue mentioned this pull request Mar 4, 2022
5 tasks
zemyblue added a commit to zemyblue/finschia-sdk that referenced this pull request Mar 4, 2022
* main: (94 commits)
  chore: release 0.45.0-rc0
  docs: add removed custom encoder's info to changelog
  docs: update changelog
  fix: remove source and builder option from wasm tx store-and-instantiate command's help
  build: change depended wasmvm version to 0.16.3-0.9.0
  fix: fix proto's comment and update swagger.yaml about proto
  chore: make format && make lint-fix
  fix: make lint-fix and fix errors
  feat: Migrate token module from line/link (Finschia#416)
  build(deps): bump github.com/line/ostracon from 1.0.2 to 1.0.3 (Finschia#418)
  fix: apply fix from release branch (Finschia#441)
  chore: make format
  chore: remove unused file
  chore: go fmt
  Ensure query isolation (Finschia#611)
  Optimize BalanceQuery
  Fix query handler instantiation
  Add decorator options
  Keeper tests (Finschia#590)
  Simplify filter method
  ...

# Conflicts:
#	CHANGELOG.md
#	go.sum
#	simapp/app.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: improvement Changes in existing functionality C:x/token
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants