Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update documents on x/consortium #490

Merged
merged 14 commits into from
Apr 18, 2022
Merged

docs: update documents on x/consortium #490

merged 14 commits into from
Apr 18, 2022

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Mar 30, 2022 •
edited
Loading

Description

closes: #484

Motivation and context

Refer to #484.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes. [no need]
  • I have updated the documentation accordingly. [no need]
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml [no need]

@0Tech 0Tech added the documentation Improvements or additions to documentation label Mar 30, 2022
@0Tech 0Tech self-assigned this Mar 30, 2022
@0Tech 0Tech changed the title Update documents on x/consortium docs: update documents on x/consortium Mar 30, 2022
@0Tech
Copy link
Collaborator Author

0Tech commented Mar 30, 2022

Waiting for merging #483, so I can confirm the references work correctly.

@0Tech 0Tech marked this pull request as ready for review March 30, 2022 09:49
@0Tech 0Tech requested review from dudong2 and zemyblue March 30, 2022 09:50
@0Tech 0Tech mentioned this pull request Mar 30, 2022
Open
zemyblue
zemyblue reviewed Apr 1, 2022
View reviewed changes
x/consortium/spec/01_concepts.md Show resolved Hide resolved
x/consortium/spec/01_concepts.md Outdated Show resolved Hide resolved
x/consortium/spec/03_events.md Show resolved Hide resolved
@0Tech
Copy link
Collaborator Author

0Tech commented Apr 6, 2022

I have confirmed all the references work as expected, after merging #483.

zemyblue
zemyblue approved these changes Apr 18, 2022
View reviewed changes
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dudong2
dudong2 approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@dudong2 dudong2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0Tech 0Tech merged commit 9b1afeb into Finschia:main Apr 18, 2022
@0Tech 0Tech deleted the consortium_spec branch April 18, 2022 07:28
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
Merged
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
Merged
5 tasks
@0Tech 0Tech added the C:x/foundation x/foundation module label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zemyblue zemyblue zemyblue approved these changes

@dudong2 dudong2 dudong2 approved these changes

Assignees

@0Tech 0Tech

Labels
C:x/foundation x/foundation module documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update documents on x/consortium
3 participants
@0Tech @zemyblue @dudong2