feat: add x/collection proto #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zemyblue
approved these changes
Jun 28, 2022
dudong2
approved these changes
Jul 4, 2022
which returns fully qualified message type name of the token class.
|
@ByunghyunBang If there is no more issue, please approve this PR. It's blocking #574. |
ByunghyunBang
approved these changes
Jul 18, 2022
Codecov Report
@@ Coverage Diff @@
## main #571 +/- ##
==========================================
- Coverage 57.55% 57.55% -0.01%
==========================================
Files 797 797
Lines 87593 87593
==========================================
- Hits 50416 50413 -3
- Misses 34035 34037 +2
- Partials 3142 3143 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #487
Motivation and context
Before adding the entire implementation of x/collection, I upload its proto first for the review.
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml