Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the order of events #599

Merged
merged 5 commits into from
Jul 26, 2022
Merged

fix: fix the order of events #599

merged 5 commits into from
Jul 26, 2022

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Jul 18, 2022

Description

This patch modifies the order in which events are raised. Also, it adds the unit tests on the events.

Motivation and context

It should assure the following conditions:

  • EventIssue (and the corresponding legacy event) is raised before the relevant events on its contract id.
  • The format of the legacy grant event on Msg/Issue is different from that on Msg/Grant.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech added the A: bug Something isn't working label Jul 18, 2022
@0Tech 0Tech self-assigned this Jul 18, 2022
@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #599 (f5249a8) into main (253d07e) will increase coverage by 0.26%.
The diff coverage is 98.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #599      +/-   ##
==========================================
+ Coverage   59.42%   59.68%   +0.26%     
==========================================
  Files         814      814              
  Lines       95390    95454      +64     
==========================================
+ Hits        56685    56973     +288     
+ Misses      35168    34902     -266     
- Partials     3537     3579      +42     
Impacted Files Coverage Δ
x/token/keeper/supply.go 91.01% <89.47%> (+0.24%) ⬆️
x/token/event.go 100.00% <100.00%> (+96.40%) ⬆️
x/token/keeper/msg_server.go 69.56% <100.00%> (+2.89%) ⬆️
x/foundation/msgs.go 39.42% <0.00%> (-7.22%) ⬇️
x/collection/collection.go 83.33% <0.00%> (-1.86%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 82.45% <0.00%> (-1.76%) ⬇️
x/wasm/keeper/keeper.go 85.74% <0.00%> (-0.36%) ⬇️
x/foundation/foundation.go 74.72% <0.00%> (+2.52%) ⬆️
x/token/msgs.go 41.57% <0.00%> (+5.73%) ⬆️
x/collection/msgs.go 42.06% <0.00%> (+7.27%) ⬆️
... and 2 more

@0Tech 0Tech requested review from dudong2 and zemyblue July 18, 2022 07:44
@0Tech 0Tech marked this pull request as ready for review July 18, 2022 07:44
x/token/event.go Outdated Show resolved Hide resolved
@0Tech 0Tech merged commit 86bb7a8 into Finschia:main Jul 26, 2022
@0Tech 0Tech deleted the token branch July 26, 2022 01:23
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working C:x/token
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants