Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change amino codec path from lbm-sdk/ to cosmos-sdk/ #600

Merged
merged 4 commits into from
Jul 19, 2022

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Jul 19, 2022

Description

change legacy amino codec path from lbm-sdk/ to cosmos-sdk/

Below modules's codec path are changed.

  • auth
  • bank
  • crisis
  • distribution
  • evidence
  • gov
  • transfer type of ibc
  • params
  • slashig
  • upgrade

Motivation and context

Change the gRPC path to the path of the original cosmos-sdk was completed in #564 , but legacy amino still has lbm-sdk as the path, so I modify it.

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue zemyblue marked this pull request as draft July 19, 2022 02:00
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #600 (95b7bd7) into main (aef879d) will increase coverage by 2.95%.
The diff coverage is 95.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #600      +/-   ##
==========================================
+ Coverage   57.63%   60.59%   +2.95%     
==========================================
  Files         797      815      +18     
  Lines       87546    95015    +7469     
==========================================
+ Hits        50456    57572    +7116     
- Misses      33959    34185     +226     
- Partials     3131     3258     +127     
Impacted Files Coverage Δ
x/collection/codec.go 0.00% <0.00%> (ø)
x/distribution/types/codec.go 41.66% <ø> (ø)
x/distribution/types/proposal.go 10.00% <ø> (ø)
x/evidence/types/codec.go 47.05% <ø> (ø)
x/gov/types/codec.go 38.46% <ø> (ø)
x/ibc/applications/transfer/types/codec.go 55.55% <ø> (ø)
x/params/types/proposal/codec.go 0.00% <ø> (ø)
x/params/types/proposal/proposal.go 44.23% <ø> (ø)
x/slashing/types/codec.go 50.00% <ø> (ø)
x/staking/types/codec.go 100.00% <ø> (ø)
... and 26 more

@zemyblue zemyblue self-assigned this Jul 19, 2022
@zemyblue zemyblue requested review from dudong2 and 0Tech July 19, 2022 05:22
@zemyblue zemyblue assigned torao and tnasu and unassigned torao and tnasu Jul 19, 2022
@zemyblue zemyblue requested review from tnasu and torao July 19, 2022 05:22
Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue zemyblue marked this pull request as ready for review July 19, 2022 05:32
Copy link
Collaborator

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Youngtaek Yoon <noreply@yoon.anonaddy.me>
@zemyblue zemyblue merged commit c0ce87f into Finschia:main Jul 19, 2022
torao pushed a commit to torao/finschia-sdk that referenced this pull request Jul 19, 2022
…hia#600)

* feat: change amino codec path from `lbm-sdk/` to `cosmos-sdk/`

Signed-off-by: zemyblue <zemyblue@gmail.com>

* chore: add changelog.

Signed-off-by: zemyblue <zemyblue@gmail.com>

* Update CHANGELOG.md

Co-authored-by: Youngtaek Yoon <noreply@yoon.anonaddy.me>

Co-authored-by: Youngtaek Yoon <noreply@yoon.anonaddy.me>
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
@zemyblue zemyblue deleted the replace_sdk branch December 23, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants