Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add iterator feature #620

Merged
merged 2 commits into from
Aug 2, 2022
Merged

chore: add iterator feature #620

merged 2 commits into from
Aug 2, 2022

Conversation

shiki-tak
Copy link
Contributor

@shiki-tak shiki-tak commented Aug 2, 2022

Description

I added iterator feature for simapp

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@shiki-tak shiki-tak self-assigned this Aug 2, 2022
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog.

@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #620 (d7477ea) into main (7b64b7a) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head d7477ea differs from pull request most recent head 2d0c361. Consider uploading reports for the commit 2d0c361 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
- Coverage   59.72%   59.70%   -0.03%     
==========================================
  Files         811      811              
  Lines       94491    94491              
==========================================
- Hits        56438    56414      -24     
- Misses      34602    34630      +28     
+ Partials     3451     3447       -4     
Impacted Files Coverage Δ
simapp/app.go 87.82% <100.00%> (ø)
x/foundation/authz.go 80.00% <0.00%> (-20.00%) ⬇️
x/token/validation.go 72.72% <0.00%> (-16.37%) ⬇️
x/foundation/foundation.go 70.75% <0.00%> (-3.98%) ⬇️
x/token/msgs.go 32.48% <0.00%> (-2.04%) ⬇️
x/collection/msgs.go 34.81% <0.00%> (-0.93%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 84.21% <0.00%> (+1.75%) ⬆️
x/foundation/msgs.go 42.30% <0.00%> (+2.88%) ⬆️

@shiki-tak shiki-tak merged commit a39ca17 into Finschia:main Aug 2, 2022
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants