Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix to prevent accepting file name #690

Merged
merged 6 commits into from
Oct 12, 2022
Merged

fix: fix to prevent accepting file name #690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f3c69cf
fix: fix to prevent accepting file name
da1suk8 Sep 30, 2022
1f70048
Update a download file name and add test cases (#1)
tnasu Oct 11, 2022
529ae38
Merge branch 'main' into fix/fix_GetCmdQueryCode
da1suk8 Oct 11, 2022
c9af254
fix: go.mod
da1suk8 Oct 11, 2022
a71b193
docs: update CHANGELOG.md
da1suk8 Oct 11, 2022
5a1c476
Merge branch 'main' into fix/fix_GetCmdQueryCode
da1suk8 Oct 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (x/foundation) [\#693](https://github.com/line/lbm-sdk/pull/693) add pool to the state of x/foundation
* (x/wasm,distribution) [\#696](https://github.com/line/lbm-sdk/pull/696) x/wasm,distribution - add checking a file size before reading it
* (x/foundation) [\#698](https://github.com/line/lbm-sdk/pull/698) update x/group relevant logic in x/foundation
* (x) [\#691](https://github.com/line/lbm-sdk/pull/691) change AccAddressFromBech32 to MustAccAddressFromBech32
* (x/auth,bank,foundation,wasm) [\#691](https://github.com/line/lbm-sdk/pull/691) change AccAddressFromBech32 to MustAccAddressFromBech32
* (x/wasm) [\#690](https://github.com/line/lbm-sdk/pull/690) fix to prevent accepting file name

### Bug Fixes
* (x/wasm) [\#453](https://github.com/line/lbm-sdk/pull/453) modify wasm grpc query api path
Expand Down
1 change: 1 addition & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ require (
github.com/sasha-s/go-deadlock v0.2.1-0.20190427202633-1595213edefa // indirect
github.com/spf13/afero v1.8.2 // indirect
github.com/spf13/jwalterweatherman v1.1.0 // indirect
github.com/stretchr/objx v0.4.0 // indirect
github.com/subosito/gotenv v1.4.1 // indirect
github.com/tendermint/tendermint v0.34.19 // indirect
github.com/zondax/hid v0.9.0 // indirect
Expand Down
13 changes: 7 additions & 6 deletions x/wasm/client/cli/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,11 +146,11 @@ func GetCmdListContractByCode() *cobra.Command {
// GetCmdQueryCode returns the bytecode for a given contract
func GetCmdQueryCode() *cobra.Command {
cmd := &cobra.Command{
Use: "code [code_id] [output filename]",
Short: "Downloads wasm bytecode for given code id",
Long: "Downloads wasm bytecode for given code id",
Use: "code [code_id]",
Short: "Downloads wasm bytecode for given code id to the current directory",
Long: "Downloads wasm bytecode for given code id to the current directory as `contract-[code_id].wasm`",
Aliases: []string{"source-code", "source"},
Args: cobra.ExactArgs(2),
Args: cobra.ExactArgs(1),
RunE: func(cmd *cobra.Command, args []string) error {
clientCtx, err := client.GetClientQueryContext(cmd)
if err != nil {
Expand All @@ -176,8 +176,9 @@ func GetCmdQueryCode() *cobra.Command {
return fmt.Errorf("contract not found")
}

fmt.Printf("Downloading wasm code to %s\n", args[1])
return os.WriteFile(args[1], res.Data, 0600)
fileName := "contract-" + strconv.FormatUint(codeID, 10) + ".wasm"
fmt.Printf("Downloading wasm code to %s\n", fileName)
return os.WriteFile(fileName, res.Data, 0600)
},
}
flags.AddQueryFlagsToCmd(cmd)
Expand Down
Loading