feat: add ReadFileWithSizeLimit and use it on x/wasm
#696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #696 +/- ##
==========================================
+ Coverage 61.18% 61.23% +0.05%
==========================================
Files 873 874 +1
Lines 98501 98546 +45
==========================================
+ Hits 60265 60349 +84
+ Misses 34667 34619 -48
- Partials 3569 3578 +9
|
tnasu
changed the title
ReadFileWithSizeLimit and use it on x/wasmReadFileWithSizeLimit and use it on x/wasm
tnasu
changed the title
ReadFileWithSizeLimit and use it on x/wasmReadFileWithSizeLimit and use it on x/wasm
zemyblue
approved these changes
Oct 6, 2022
|
Add to address it on x/distribution |
zemyblue
reviewed
Oct 11, 2022
CHANGELOG.md
Outdated
Comment on lines
76
to
77
| * (x/wasm) [\#696](https://github.com/line/lbm-sdk/pull/696) x/wasm - add checking a wasm file size before reading it | ||
| * (x/distribution) [\#696](https://github.com/line/lbm-sdk/pull/696) x/distribution - add checking a proposal file size before reading it |
zemyblue
approved these changes
Oct 11, 2022
dudong2
approved these changes
Oct 11, 2022
3 tasks
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reading a huge file has the risk of the crash application by using
ioutil.ReadFile/os.ReadFile.Here is the updates:
ReadFileWithSizeLimitMotivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml