Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: revisit foundation operator #744

Merged
merged 11 commits into from Oct 21, 2022
Merged

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Oct 20, 2022

Description

This patch will replace the foundation operator into the module's authority. As of now, the authority MUST be the module account of x/foundation.
Someday, we may change the authority to x/gov's. This patch would open the possibility.

closes: #741

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech self-assigned this Oct 20, 2022
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #744 (989bc3a) into main (da194c7) will decrease coverage by 0.05%.
The diff coverage is 98.52%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #744      +/-   ##
==========================================
- Coverage   62.08%   62.03%   -0.06%     
==========================================
  Files         877      877              
  Lines       98970    98948      -22     
==========================================
- Hits        61450    61382      -68     
- Misses      33900    33955      +55     
+ Partials     3620     3611       -9     
Impacted Files Coverage Δ
x/foundation/keeper/exec.go 93.05% <85.71%> (+0.19%) ⬆️
simapp/app.go 86.11% <100.00%> (ø)
x/foundation/client/testutil/suite.go 97.68% <100.00%> (-0.17%) ⬇️
x/foundation/client/testutil/tx.go 100.00% <100.00%> (ø)
x/foundation/genesis.go 83.21% <100.00%> (-0.46%) ⬇️
x/foundation/keeper/genesis.go 96.77% <100.00%> (-0.41%) ⬇️
x/foundation/keeper/keeper.go 89.47% <100.00%> (+6.14%) ⬆️
x/foundation/keeper/member.go 95.00% <100.00%> (-0.21%) ⬇️
x/foundation/keeper/msg_server.go 84.91% <100.00%> (ø)
x/foundation/keeper/proposal.go 88.69% <100.00%> (ø)
... and 4 more

@zemyblue zemyblue added the C:x/foundation x/foundation module label Oct 21, 2022
@0Tech 0Tech marked this pull request as ready for review October 21, 2022 01:43
Copy link
Member

@tkxkd0159 tkxkd0159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0Tech 0Tech merged commit fee8f64 into Finschia:main Oct 21, 2022
@0Tech 0Tech deleted the foundation_authority branch October 21, 2022 04:08
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/foundation x/foundation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit the naming of operator in x/foundation
3 participants