fix: restore build norace flag #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkxkd0159
reviewed
Oct 27, 2022
| @@ -1,3 +1,6 @@ | |||
| //go:build norace | |||
| // +build norace | |||
There was a problem hiding this comment.
Is there any reason to use this redundant constraint? Because go:build is enough after go 1.17.
There was a problem hiding this comment.
I know about that. However, when i save the code in the IDE, it automatically generates +build norace.
zemyblue
approved these changes
Oct 27, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #761 +/- ##
==========================================
+ Coverage 62.13% 62.20% +0.07%
==========================================
Files 880 880
Lines 99479 99479
==========================================
+ Hits 61807 61880 +73
+ Misses 34071 33982 -89
- Partials 3601 3617 +16
|
tkxkd0159
approved these changes
Oct 27, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Restores the removeed
build noraceflag.ref. #709
closes: #762
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml