Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix x/collection ModifyContract #798

Merged
merged 3 commits into from
Nov 16, 2022
Merged

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Nov 14, 2022

Description

closes: #797

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech added A: bug Something isn't working C:x/collection C:x/token labels Nov 14, 2022
@0Tech 0Tech self-assigned this Nov 14, 2022
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #798 (59700ac) into rc9/v0.46.0 (6792efe) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           rc9/v0.46.0     #798      +/-   ##
===============================================
+ Coverage        62.15%   62.22%   +0.06%     
===============================================
  Files              877      877              
  Lines            99419    99419              
===============================================
+ Hits             61796    61860      +64     
+ Misses           34019    33927      -92     
- Partials          3604     3632      +28     
Impacted Files Coverage Δ
x/collection/keeper/supply.go 89.11% <100.00%> (ø)
x/token/validation.go 87.27% <0.00%> (+1.81%) ⬆️
x/token/msgs.go 52.47% <0.00%> (+3.04%) ⬆️
x/collection/msgs.go 55.65% <0.00%> (+7.73%) ⬆️
x/token/token.go 100.00% <0.00%> (+50.00%) ⬆️

@0Tech 0Tech marked this pull request as ready for review November 14, 2022 08:07
@0Tech 0Tech merged commit 3330562 into Finschia:rc9/v0.46.0 Nov 16, 2022
@0Tech 0Tech deleted the fix_modify branch November 16, 2022 04:39
This was referenced Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants