feat: add calculate instantiate cost function into get contract env api #835
+220
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 16, 2022
Merged
|
LGTM |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dynamic_link #835 +/- ##
=============================================
Coverage 61.08% 61.08%
=============================================
Files 873 873
Lines 98602 98628 +26
=============================================
+ Hits 60231 60249 +18
- Misses 34767 34785 +18
+ Partials 3604 3594 -10
|
This is caused by a bug fix for the gas value for human address API in x/wasm/keeper/api.wasm.
This API is used in the hackatom contract.
correspond bug fix:
--- a/x/wasm/keeper/api.go
+++ b/x/wasm/keeper/api.go
@@ -27,7 +26,8 @@ var (
)
func (a cosmwasmAPIImpl) humanAddress(canon []byte) (string, uint64, error) {
- gas := a.gasMultiplier.FromWasmVMGas(5)
+ gasMultiplier := a.keeper.getGasMultiplier(*a.ctx)
+ gas := gasMultiplier.ToWasmVMGas(5)
if err := sdk.VerifyAddressFormat(canon); err != nil {
return "", gas, err
}
zemyblue
approved these changes
Jan 2, 2023
da1suk8
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes GetContractEnv wasm API for x/wasm able to calculate instantiate cost. This function uses the input length in the calculation, so this PR adds it and arg for return as new args of the GetContractEnv.
Motivation and context
This is used for costing instantiate cost to callings of dynamic functions (Finschia/cosmwasm#257). It also works as the limit of the length of inputs of callings of dynamic functions.
How has this been tested?
This PR modifies some unit tests.
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml(not needed)