Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: apply changes to replace Ostracon proto message with Tendermint #869

Merged
merged 11 commits into from
Feb 6, 2023

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Jan 26, 2023

Description

apply changes to replace Ostracon proto message with Tendermint (Finschia/ostracon#546)

Breaking changes

This changes has breaking change.

  • The snapshot data is changed because the proto file of ostracon is changed.

Motivation and context

The reason is same with Finschia/ostracon#546 change.

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

 - (replace a some same proto message to Tendermint )
@zemyblue zemyblue marked this pull request as draft January 26, 2023 13:46
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #869 (c506b53) into main (611b286) will increase coverage by 0.07%.
The diff coverage is 85.74%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #869      +/-   ##
==========================================
+ Coverage   62.37%   62.45%   +0.07%     
==========================================
  Files         653      653              
  Lines       79976    79873     -103     
==========================================
- Hits        49885    49884       -1     
+ Misses      27399    27298     -101     
+ Partials     2692     2691       -1     
Impacted Files Coverage Δ
baseapp/grpcrouter.go 85.93% <ø> (ø)
baseapp/grpcrouter_helpers.go 29.62% <ø> (ø)
baseapp/p2p.go 67.74% <ø> (ø)
baseapp/reactor.go 10.71% <0.00%> (ø)
client/flags/flags.go 89.47% <ø> (-0.36%) ⬇️
client/grpc/tmservice/service.go 68.75% <ø> (ø)
client/grpc_query.go 36.50% <ø> (ø)
client/query.go 30.95% <ø> (ø)
server/rosetta/client_online.go 1.70% <0.00%> (ø)
server/rosetta/converter.go 56.57% <ø> (ø)
... and 93 more

* main:
  chore(deps): Bump docker/build-push-action from 3 to 4 (Finschia#874)
  chore(deps): Bump github.com/spf13/viper from 1.14.0 to 1.15.0 (Finschia#867)
  chore(deps): Bump actions/cache from 3.2.3 to 3.2.4 (Finschia#873)
  fix!: Fix foundation amino codec (Finschia#833) (Finschia#862)

# Conflicts:
#	go.mod
#	go.sum
@0Tech
Copy link
Collaborator

0Tech commented Feb 2, 2023

@zemyblue zemyblue self-assigned this Feb 2, 2023
@0Tech
Copy link
Collaborator

0Tech commented Feb 3, 2023

You may revert my previous suggestion. It seems the logic relevant to log parsing has been changed in this PR.
Simple solution is to specify the log_level on query.

To reproduce the CI failure, you must wipe out ~/.simapp in your environment.

Refer: 0Tech#4.

@0Tech 0Tech mentioned this pull request Feb 3, 2023
@zemyblue zemyblue marked this pull request as ready for review February 3, 2023 08:17
@zemyblue
Copy link
Member Author

zemyblue commented Feb 3, 2023

I want to ignore codecov error of ci Because this PR almost change the imported path and Ostracon's proto path, so many files are changed but some files do not have unittest or low coverage. I cannot add unittest of these all files.

baseapp/abci_test.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
proto/cosmos/tx/v1beta1/service.proto Outdated Show resolved Hide resolved
server/start.go Outdated Show resolved Hide resolved
types/result.go Outdated Show resolved Hide resolved
* main:
  feat!: add MultiSend deactivation (Finschia#876)
  chore(deps): Bump github.com/gogo/protobuf in /ics23/go (Finschia#816)
  fix: do not create account on x/token,collection (Finschia#866)
  fix!: update x/collection,token proto (Finschia#863)

# Conflicts:
#	CHANGELOG.md
@zemyblue zemyblue added this to the v0.47.0-alpha1 milestone Feb 6, 2023
@zemyblue
Copy link
Member Author

zemyblue commented Feb 6, 2023

Ci Unittest error is occurred by #876 (comment).
And this problem will fix by #882 .

@zemyblue zemyblue requested a review from dudong2 February 6, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants