Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change the default params of x/collection #894

Merged
merged 3 commits into from
Feb 13, 2023

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Feb 13, 2023

Description

This patch would change the default value of DepthLimit and WidthLimit of x/collection, which constrains the size of hierarchies of composable nfts on x/collection.

Motivation and context

Business requirement.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech self-assigned this Feb 13, 2023
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #894 (8cceb34) into main (5a8d776) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #894   +/-   ##
=======================================
  Coverage   62.31%   62.31%           
=======================================
  Files         653      653           
  Lines       79497    79510   +13     
=======================================
+ Hits        49537    49550   +13     
  Misses      27280    27280           
  Partials     2680     2680           
Impacted Files Coverage Δ
x/collection/genesis.go 93.20% <ø> (ø)
x/collection/client/testutil/suite.go 99.62% <100.00%> (+0.01%) ⬆️
x/collection/keeper/genesis.go 97.04% <100.00%> (ø)
x/collection/keeper/param.go 77.77% <100.00%> (ø)

@0Tech 0Tech marked this pull request as ready for review February 13, 2023 01:51
@0Tech 0Tech requested review from dudong2, jaeseung-bae, loin3, tkxkd0159 and zemyblue and removed request for loin3 February 13, 2023 01:51
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zemyblue zemyblue added this to the v0.47.0-alpha1 milestone Feb 13, 2023
@0Tech 0Tech merged commit cb6f186 into Finschia:main Feb 13, 2023
@0Tech 0Tech deleted the collection_params branch February 13, 2023 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants