feat!: remove libsodium vrf library.
#240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
zemyblue
changed the title
libsodium vrf library.
Signed-off-by: zemyblue <zemyblue@gmail.com>
zemyblue
requested review from
torao,
tnasu,
0Tech,
dudong2,
ulbqb,
loin3 and
jaeseung-bae
Signed-off-by: zemyblue <zemyblue@gmail.com>
ulbqb
approved these changes
Jul 20, 2023
This was referenced Aug 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove unused shared library
The
libsodiumvrf library doesn't need any more through Finschia/ostracon#652.So I remove it for preparing single binaries on macos. This is related with #231.
To build single binary, there should be no dynamic library except
cleveldb.Motivation and context
Ostracon does not use the
libsodiumvrf library and it changed tocurve25519-voi. Solibsodiumsubmodule and build scripts are not need any more. And I need this remove any dynamic libraries or change to static libraries for building single binary on macos. So I need to remove libsodium first.How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md