Backport tendermint-v0.34.20 into main #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnasu
added
the
C: enhancement
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #642 +/- ##
==========================================
+ Coverage 66.15% 66.25% +0.10%
==========================================
Files 277 279 +2
Lines 37001 37157 +156
==========================================
+ Hits 24477 24620 +143
- Misses 10763 10766 +3
- Partials 1761 1771 +10
|
tnasu
force-pushed
the
main-v0.34.20
branch
8 times, most recently
from
14280ff
to
4c4b5f9
Compare
9 tasks
Co-authored-by: Sam Kleinman <garen@tychoish.com>
A manual backport of #7263. As a safety measure, don't allow a query string to be unreasonably long. The query filter is not especially efficient, so a query that needs more than basic detail should filter coarsely in the subscriber and refine on the client side. This affects Subscribe and TxSearch queries. Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
* makefile: update buf commands to use tools.go (#8609) This will keep the version of `buf` consistent between all developer machines. Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>
Co-authored-by: Joe Abbey <joe.abbey@gmail.com>
Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>
… of tendermint-v0.34.21: tendermint/tendermint@c723357
tnasu
force-pushed
the
main-v0.34.20
branch
2 times, most recently
from
611c340
to
268652c
Compare
* Updated mocks * add reactor tests * add v1 reactor tests * Fix fuzz test for priority mempool * e2e adapted to mempool v1; prio pool is default now * Reverted default mempool to be fifo * Changed buf version * Added priority mempool to ci testnet * Fixed linter * Updated makefile * Aligned makefile changes to v0.34.x * Added go install for proto * Add log message to warn about prioritized mempool bug Signed-off-by: Thane Thomson <connect@thanethomson.com> * Changelog message Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com> Co-authored-by: Callum Waters <cmwaters19@gmail.com> Co-authored-by: Sam Kleinman <garen@tychoish.com> Co-authored-by: Thane Thomson <connect@thanethomson.com>
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
This is a manual backport of the changes from these commits: - bc49f66 Add more unit tests for the priority mempool. (#8961) - 9b02094 Fix unbounded heap growth in the priority mempool. (#8944) Imports and type signatures have been updated to match the v0.34 usage. Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
- Remove warning log for issue #8775. - Fix call to FlushAsync (no error is reported). - Don't log on rechecks, it's the default (manual backport of #8969). Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
A manual cherry-pick of 9e64c95. The way this was originally structured, we reacquired the lock after issuing the initial ABCI CheckTx call, only to immediately release it. Restructure the code so that this redundant acquire is no longer necessary. Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
A manual backport of #8984. This case is symmetric to what we did for CheckTx calls, where we release the mempool mutex to ensure callbacks can fire during call setup. We also need this behaviour for application flush, for the same reason: The caller holds the lock by contract from the Mempool interface. Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
…port #9000) (#9004) This is a manual cherry-pick of commit b94470a6a42e8ffe7e7467521de5f51eb937c454. In the original implementation transactions evicted for priority were also removed from the cache. In addition, remove expired transactions from the cache. Related: - Add Has method to cache implementations. - Update tests to exercise this condition. Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
In the v0.34 line, the socket and gRPC clients require explicit flushes to ensure that the client and server have received an async request. Add these calls explicitly where required in the backport of the priority mempool. In addition, the gRPC client's flush plumbing was not fully hooked up in the v0.34 line, so this change includes that update as well. Co-authored: M. J. Fromberger <fromberger@interchain.io>
ulbqb
previously approved these changes
Jul 18, 2023
torao
approved these changes
Jul 19, 2023
ulbqb
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
v0.34.20
STATUS: commit hash
abci.Client, Async() interfaces #169Upgrade
tendermint-v0.34.20