feat: change tag name for static build #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change tag name: muslc -> static - unify link_muslc.go and link_static.go -> link_static.go - update build files: Dockerfile, Makefile
|
Added linux static test. PTAL |
brew0722
reviewed
Oct 1, 2021
| # build a go binary | ||
| docker run --rm -u $(USER_ID):$(USER_GROUP) -v $(shell pwd):/code -w /code $(BUILDERS_PREFIX):static go build -tags='static mocks' -o static.exe ./cmd | ||
| # run static binary in an alpine machines (not dlls) | ||
| docker run --rm --read-only -v $(shell pwd):/code -w /code centos ./static.exe ./api/testdata/hackatom.wasm |
There was a problem hiding this comment.
how about choice a more specific the centos version?
used 7 when building, so I think it would be good to specify 7 in the test as well.
| test-static: release-build-linux-static | ||
| # build a go binary | ||
| docker run --rm -u $(USER_ID):$(USER_GROUP) -v $(shell pwd):/code -w /code $(BUILDERS_PREFIX):static go build -tags='static mocks' -o static.exe ./cmd | ||
| # run static binary in an alpine machines (not dlls) |
There was a problem hiding this comment.
Is it right that 'dlls' to windows dlls? It seems unfamiliar Windows terminology in the linux environment.
There was a problem hiding this comment.
Thanks! I will fix the comment in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
change tag name for static build
Types of changes
Checklist