-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin version of firebase-tools used for deploys. #242
Comments
Hey @mikelehen! I think adding a version override is more than a reasonable option for starters. I'll look into some options for improvement here and get back to you. |
+1 to pinning the dependency. I know it would require an action release every time the internal version was to be updated; but this would be correct, and would mirror the way other GitHub Actions generally work. |
+1, great idea @mikelehen |
Awesome, thanks @davideast! |
Thanks for the feedback all! |
The use case you're trying to solve
Github deploys work reliably from day to day.
Change to the action that would solve that use case
Instead of installing the latest firebese-tools every time, pin to a version that is known to work correctly and only update it periodically. Perhaps allow developers to override the version if they choose.
Other considerations
For context, the firebase-tools@11.14.0 release had a regression that broke deploys for many firebase projects. firebase/firebase-tools#5071
I don't need my automatic deploys to be using the absolute latest version of firebase-tools. I'd rather it only update occasionally so that I'm not subject to surprise breakages.
The text was updated successfully, but these errors were encountered: