Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated guides with $firebaseAuth issues #743 #751

Merged
merged 4 commits into from
Jun 2, 2016

Conversation

matheushf
Copy link
Contributor

Guides updated with fix related to issue #743

@jwngr
Copy link

jwngr commented Jun 2, 2016

Thanks for the PR! I think we just want to make sure all the docs are for the newest code, so let's go ahead and just keep the var auth = $firebaseAuth(); lines in all these and remove the rest. Thanks for catching our mistake!

@jwngr
Copy link

jwngr commented Jun 2, 2016

You missed one last one in docs/quickstart.md that needs to be slimmed one.

@matheushf
Copy link
Contributor Author

Oh sorry! I forgot that last one

@jwngr
Copy link

jwngr commented Jun 2, 2016

Looks good. Thanks for the PR and helping us improve our docs!

@jwngr jwngr merged commit c4e1a9c into FirebaseExtended:master Jun 2, 2016
@jwngr jwngr self-assigned this Jun 2, 2016
@matheushf matheushf deleted the patch-1 branch June 2, 2016 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants