Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including declarations files #227

Merged
merged 1 commit into from
Apr 6, 2018
Merged

Conversation

andrioli
Copy link
Contributor

@andrioli andrioli commented Apr 6, 2018

@rockwotj This is an alternative PR for #211

FYI @wcandillon

@rockwotj rockwotj self-requested a review April 6, 2018 17:29
Copy link
Collaborator

@rockwotj rockwotj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rockwotj rockwotj merged commit d0c53f2 into FirebaseExtended:master Apr 6, 2018
@rockwotj rockwotj mentioned this pull request Apr 6, 2018
@rockwotj
Copy link
Collaborator

rockwotj commented Apr 6, 2018

(also I need to figure out the internal release process for this and I'll release a new patch version here).

rockwotj added a commit that referenced this pull request Apr 6, 2018
Add the feature from #227 into the changelog
@rockwotj rockwotj mentioned this pull request Apr 6, 2018
rockwotj added a commit that referenced this pull request Apr 6, 2018
Add the feature from #227 into the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants