Add sign in and sign up with Google to Android samples #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marinacoelho
changed the title
peterfriese
reviewed
May 3, 2024
There was a problem hiding this comment.
I'd prefer if we used the same directory structure as for Apple:
firebase-video-samples/fundamentals/apple at main · FirebaseExtended/firebase-video-samples
I assume this PR uses the new (?) Sign in with Google, so I'd be OK with "auth-sign-in-with-google".
thatfiredev
reviewed
May 7, 2024
...uth-SiWG/Notes/app/src/main/java/com/notes/app/screens/account_center/AccountCenterScreen.kt
Outdated
Show resolved
Hide resolved
...uth-SiWG/Notes/app/src/main/java/com/notes/app/screens/account_center/AccountCenterScreen.kt
Outdated
Show resolved
Hide resolved
...-SiWG/Notes/app/src/main/java/com/notes/app/screens/account_center/AccountCenterViewModel.kt
Outdated
Show resolved
Hide resolved
thatfiredev
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new folder to the android video samples folder. It contains the sample code for sign in and sign up with Google using Credential Manager.
Most of the new files are the same from the previous code sample (built for the anonymous authentication video), so focus on the review of:
build.gradle.ktsAccountService.ktAccountServiceImpl.ktAccountCenterButtons.ktSignInScreen.ktSignInViewModel.ktSignUpScreen.ktSignUpViewModel.ktThis is how the new UI looks like: