Monaco undo affects other user #398
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 952676946Details
💛 - Coveralls |
0xTheProDev
reviewed
Jun 20, 2021
| @@ -272,7 +272,7 @@ var MonacoAdapter = function () { | |||
| */ | |||
| MonacoAdapter.prototype.registerUndo = function registerUndo(callback) { | |||
| if (typeof callback === 'function') { | |||
| this.callbacks.undo = callback; | |||
There was a problem hiding this comment.
registerUndo is called once during initialisation, but internally monaco can change model. This is required to handle such scenario. Rest looks fine. Thank you!
There was a problem hiding this comment.
I don't think my approach is right as it can go out of sync and generate errors. Can you think of a way to solve this?
There was a problem hiding this comment.
I am yet to test this out. I can look again then.
There was a problem hiding this comment.
@Progyan1997 @adamjimenez just let me know when you two are satisfied with the solution here, this is beyond my knowledge of how Monaco works so I will defer to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #397