Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flutterfire_ui README links #8630

Merged
merged 2 commits into from
May 12, 2022

Conversation

pedrobalao
Copy link
Contributor

Description

The flutterfire_ui README file had some links broken, as they were pointing to a 'docs' folder instead of 'doc'. This PR intends to fix it.

Related Issues

#8628

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • [*] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [NA] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • [NA] All existing and new tests are passing.
  • [NA] I updated/added relevant documentation (doc comments with ///).
  • [NA] The analyzer (melos run analyze) does not report any problems on my PR.
  • [*] I read and followed the [Flutter Style Guide].
  • [*] I signed the [CLA].
  • [*] I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • [*] No, this is not a breaking change.

@pedrobalao pedrobalao marked this pull request as ready for review May 10, 2022 20:17
@kevinthecheung kevinthecheung self-requested a review May 10, 2022 21:50
Copy link
Collaborator

@kevinthecheung kevinthecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more on line 58 ("Learn more in the Integrating your first screen section...").

@kevinthecheung
Copy link
Collaborator

Thanks!

@Salakar Salakar merged commit ba5b58a into firebase:master May 12, 2022
@firebase firebase locked and limited conversation to collaborators Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants