Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(firebase_messaging): Fix pod install for ImageNotification due to missing use_frameworks! flag. #7466

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

jovermars
Copy link
Contributor

Resolves error message below by also having the use_frameworks! flag set.

[!] Unable to integrate the following embedded targets with their respective host targets (a host target is a "parent" target which embeds a "child" target like a framework or extension):

  • Runner (true) and ImageNotification (false) do not both set use_frameworks!.

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

…eworks!

Resolves error message below by also having the use_frameworks! flag set.

[!] Unable to integrate the following embedded targets with their respective host targets (a host target is a "parent" target which embeds a "child" target like a framework or extension):

- Runner (true) and ImageNotification (false) do not both set use_frameworks!.
@google-cla google-cla bot added the cla: no label Dec 5, 2021
@russellwheatley russellwheatley changed the title Fix pod install for ImageNotification due to missing use_frameworks! flag docs(firebase_messaging): Fix pod install for ImageNotification due to missing use_frameworks! flag. Jan 4, 2022
@russellwheatley
Copy link
Member

Hey @jovermars, do you mind signing the CLA so we can get this merged in? Thanks.

@jovermars
Copy link
Contributor Author

Apologies and done ✅

@google-cla google-cla bot added cla: yes and removed cla: no labels Jan 4, 2022
Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russellwheatley russellwheatley merged commit 1b55c46 into firebase:master Jan 4, 2022
@firebase firebase locked and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants