Remove skip on Auth tests now that jsdom bug is fixed
#357
Conversation
|
update: this won't be ready until a series of dependencies update their jsdom version to
|
|
This is blocked on TSDX updating from Jest 25 to 26: jaredpalmer/tsdx#1003 |
jhuleatt
changed the title
skip on Auth tests!skip on Auth tests now that jsdom bug is fixed
Version 25 of jest uses a version of jsdom that has a bug that prevents it from talking to the Auth emulator.
|
trying out Yarn resolutions as suggested in jaredpalmer/tsdx#1016 (comment) |
|
Using the new Jest/jsdom fixed the Auth emulator tests, but broke the Firestore emulator tests. Trying the workaround in firebase/firebase-js-sdk#3096 (comment) to see if that helps |
|
@jamesdaniels any idea why we'd get |
|
Hm, I tried a potential fix, but ended up breaking one of the Node 12 tests too EDIT: seems like a false alarm, error in Node 12 was a grpc issue (so probably a flake). Node 10 still has the globalThis error |
|
Seems like this is a jsdom bug with Node 10: jsdom/jsdom#2795 (comment) @jamesdaniels would you be cool with dropping Node 10 from our test matrix given it is EOL this week? |
|
admin-merging this since this only affects tests (which are passing) and generated docs |
jsdom/jsdom#3073 has been merged and released in jsdom
16.5.2! This means we don't need to skip the auth tests any more!