Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rxfire/remote-config for remote config getters #434

Merged
merged 7 commits into from
Sep 1, 2021

Conversation

justjish
Copy link
Contributor

Description

Code Cleanup: remote-config

  1. Use rxfire/remote-config for remote config getters. The getValue.tsx is simply a copy from rxfire/remote-config anyway.
  2. Use the public api for getting the app name for remote config rather than a private variable.
  3. Remove @param remoteConfig Optional instance. If not provided ReactFire will either grab the default instance or lazy load. from all comments.

Code sample

N/A - Functionality remains same.

@google-cla google-cla bot added the cla: yes label Aug 27, 2021
@jhuleatt
Copy link
Collaborator

jhuleatt commented Sep 1, 2021

Thank you @sujishpatel!

@jhuleatt jhuleatt merged commit 857dbcd into FirebaseExtended:main Sep 1, 2021
@FirebaseExtended FirebaseExtended locked and limited conversation to collaborators Oct 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants