Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure Firestore hooks return undefined when data does not exist #446

Merged
merged 8 commits into from
Sep 8, 2021
Merged

Make sure Firestore hooks return undefined when data does not exist #446

merged 8 commits into from
Sep 8, 2021

Commits on Sep 7, 2021

  1. try to repro

    @jhuleatt
    jhuleatt committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    afd49bb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into jhuleatt-issue-440

    @jhuleatt
    jhuleatt committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    061fa34 View commit details
    Browse the repository at this point in the history

  3. rule out useObservable as root cause

    @jhuleatt
    jhuleatt committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    7075fde View commit details
    Browse the repository at this point in the history

  4. managed to repro with useObservable

    @jhuleatt
    jhuleatt committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    13a1ff4 View commit details
    Browse the repository at this point in the history

  5. make sure state always updates whenever "next" is called

    @jhuleatt
    jhuleatt committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    3d716ba View commit details
    Browse the repository at this point in the history

  6. remove extra console log

    @jhuleatt
    jhuleatt committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    53d4af5 View commit details
    Browse the repository at this point in the history

  7. docgen

    @jhuleatt
    jhuleatt committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    88c9658 View commit details
    Browse the repository at this point in the history

  8. update CI to firebase 9.0.1

    @jhuleatt
    jhuleatt committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    c0acc56 View commit details
    Browse the repository at this point in the history