httpsCallable type cleanup
#34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhuleatt
commented
Sep 10, 2021
| @@ -24,13 +24,13 @@ import { map } from 'rxjs/operators'; | |||
| type Functions = import('firebase/functions').Functions; | |||
| type HttpsCallableOptions = import('firebase/functions').HttpsCallableOptions; | |||
|
|
|||
| export function httpsCallable<T, R>( | |||
| export function httpsCallable<RequestData = unknown, ResponseData = unknown>( | |||
There was a problem hiding this comment.
is unknown-ing these necessary?
jamesdaniels
approved these changes
Sep 14, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update RxFire's
httpsCallableto align with the JS SDK'shttpsCallable.httpsCallable(RequestDataandResponseData)RequestDataandResponseDatato unknown, just like the JS SDK'shttpsCallabledataoptional so it matchesHttpsCallablevanillaHttpsCallableso we don't need toasthe result