Add noexcept(false) to most of dtors

FirebirdSQL · Oct 6, 2023 · 957768c · 957768c
1 parent 5327ed8
commit 957768c
Show file tree

Hide file tree

Showing 162 changed files with 544 additions and 543 deletions.
diff --git a/extern/cloop/src/cloop/Generator.cpp b/extern/cloop/src/cloop/Generator.cpp
@@ -322,7 +322,7 @@ void CppGenerator::generate()
 		fprintf(out, "\t\t{\n");
 		fprintf(out, "\t\t}\n");
 		fprintf(out, "\n");
-		fprintf(out, "\t\t~%s%s()\n", prefix.c_str(), interface->name.c_str());
+		fprintf(out, "\t\t~%s%s() noexcept(false)\n", prefix.c_str(), interface->name.c_str());
 		fprintf(out, "\t\t{\n");
 		fprintf(out, "\t\t}\n");
 		fprintf(out, "\n");
@@ -656,7 +656,7 @@ void CppGenerator::generate()
 		fprintf(out, "\t\t}\n");
 		fprintf(out, "\n");
 		fprintf(out, "\tpublic:\n");
-		fprintf(out, "\t\tvirtual ~%s%sImpl()\n", prefix.c_str(), interface->name.c_str());
+		fprintf(out, "\t\tvirtual ~%s%sImpl() noexcept(false)\n", prefix.c_str(), interface->name.c_str());
 		fprintf(out, "\t\t{\n");
 		fprintf(out, "\t\t}\n");
 		fprintf(out, "\n");

diff --git a/extern/cloop/src/tests/test1/CalcCppApi.h b/extern/cloop/src/tests/test1/CalcCppApi.h
@@ -71,7 +71,7 @@ namespace calc
 		{
 		}
 
-		~IDisposable()
+		~IDisposable() noexcept(false)
 		{
 		}
 
@@ -101,7 +101,7 @@ namespace calc
 		{
 		}
 
-		~IStatus()
+		~IStatus() noexcept(false)
 		{
 		}
 
@@ -143,7 +143,7 @@ namespace calc
 		{
 		}
 
-		~IFactory()
+		~IFactory() noexcept(false)
 		{
 		}
 
@@ -200,7 +200,7 @@ namespace calc
 		{
 		}
 
-		~ICalculator()
+		~ICalculator() noexcept(false)
 		{
 		}
 
@@ -266,7 +266,7 @@ namespace calc
 		{
 		}
 
-		~ICalculator2()
+		~ICalculator2() noexcept(false)
 		{
 		}
 
@@ -340,7 +340,7 @@ namespace calc
 		}
 
 	public:
-		virtual ~IDisposableImpl()
+		virtual ~IDisposableImpl() noexcept(false)
 		{
 		}
 
@@ -416,7 +416,7 @@ namespace calc
 		}
 
 	public:
-		virtual ~IStatusImpl()
+		virtual ~IStatusImpl() noexcept(false)
 		{
 		}
 
@@ -528,7 +528,7 @@ namespace calc
 		}
 
 	public:
-		virtual ~IFactoryImpl()
+		virtual ~IFactoryImpl() noexcept(false)
 		{
 		}
 
@@ -638,7 +638,7 @@ namespace calc
 		}
 
 	public:
-		virtual ~ICalculatorImpl()
+		virtual ~ICalculatorImpl() noexcept(false)
 		{
 		}
 
@@ -790,7 +790,7 @@ namespace calc
 		}
 
 	public:
-		virtual ~ICalculator2Impl()
+		virtual ~ICalculator2Impl() noexcept(false)
 		{
 		}
 

diff --git a/src/auth/SecDbCache.h b/src/auth/SecDbCache.h
@@ -102,7 +102,7 @@ class CachedSecurityDatabase final
 			}
 		}
 
-		~Instance()
+		~Instance() noexcept(false)
 		{
 			if (hasData())
 			{

diff --git a/src/auth/SecureRemotePassword/Message.h b/src/auth/SecureRemotePassword/Message.h
@@ -96,7 +96,7 @@ class Message
 		}
 	}
 
-	~Message()
+	~Message() noexcept(false)
 	{
 		delete[] buffer;
 #ifndef INTERNAL_FIREBIRD

diff --git a/src/burp/BurpTasks.cpp b/src/burp/BurpTasks.cpp
@@ -77,7 +77,7 @@ class BurpGblHolder
 		fb_assert(!m_prev_item || m_prev_item == item);
 	}
 
-	~BurpGblHolder()
+	~BurpGblHolder() noexcept(false)
 	{
 		BurpGlobals* gbl = BurpGlobals::getSpecific();
 		gbl->taskItem = m_prev_item;
@@ -140,7 +140,7 @@ BackupRelationTask::BackupRelationTask(BurpGlobals* tdgbl) : Task(),
 	}
 }
 
-BackupRelationTask::~BackupRelationTask()
+BackupRelationTask::~BackupRelationTask() noexcept(false)
 {
 	for (Item** p = m_items.begin(); p < m_items.end(); p++)
 	{
@@ -612,7 +612,7 @@ bool BackupRelationTask::fileWriter(Item& item)
 	return true;
 }
 
-BackupRelationTask::Item::EnsureUnlockBuffer::~EnsureUnlockBuffer()
+BackupRelationTask::Item::EnsureUnlockBuffer::~EnsureUnlockBuffer() noexcept(false)
 {
 	if (m_item && m_item->m_buffer)
 		m_item->m_buffer->unlock(true);
@@ -1098,7 +1098,7 @@ void RestoreRelationTask::putCleanBuffer(IOBuffer* buf)
 	m_cleanBuffers.push(buf);
 }
 
-RestoreRelationTask::Item::EnsureUnlockBuffer::~EnsureUnlockBuffer()
+RestoreRelationTask::Item::EnsureUnlockBuffer::~EnsureUnlockBuffer() noexcept(false)
 {
 	if (m_item && m_item->m_buffer)
 		m_item->m_buffer->unlock(true);

diff --git a/src/burp/BurpTasks.h b/src/burp/BurpTasks.h
@@ -81,7 +81,7 @@ class ReadRelationReq
 		m_request = 0;
 	}
 
-	~ReadRelationReq()
+	~ReadRelationReq() noexcept(false)
 	{
 		clear();
 	}
@@ -177,7 +177,7 @@ class WriteRelationReq
 		m_resync = true;
 	}
 
-	~WriteRelationReq()
+	~WriteRelationReq() noexcept(false)
 	{
 		clear();
 	}
@@ -239,7 +239,7 @@ class BackupRelationTask : public Firebird::Task
 {
 public:
 	BackupRelationTask(BurpGlobals* tdgbl);
-	~BackupRelationTask();
+	~BackupRelationTask() noexcept(false);
 
 	void SetRelation(burp_rel* relation);
 
@@ -273,7 +273,7 @@ class BackupRelationTask : public Firebird::Task
 		{
 		public:
 			EnsureUnlockBuffer(Item* item) : m_item(item) {}
-			~EnsureUnlockBuffer();
+			~EnsureUnlockBuffer() noexcept(false);
 
 		private:
 			Item* m_item;
@@ -346,7 +346,7 @@ class RestoreRelationTask : public Firebird::Task
 {
 public:
 	RestoreRelationTask(BurpGlobals* tdgbl);
-	~RestoreRelationTask();
+	~RestoreRelationTask() noexcept(false);
 
 	void SetRelation(BurpGlobals* tdgbl, burp_rel* relation);
 
@@ -378,7 +378,7 @@ class RestoreRelationTask : public Firebird::Task
 		{
 		public:
 			EnsureUnlockBuffer(Item* item) : m_item(item) {}
-			~EnsureUnlockBuffer();
+			~EnsureUnlockBuffer() noexcept(false);
 
 		private:
 			Item* m_item;
@@ -593,7 +593,7 @@ class BurpMaster
 			m_task->burpOutMutex.enter(FB_FUNCTION);
 	}
 
-	~BurpMaster()
+	~BurpMaster() noexcept(false)
 	{
 		if (m_task)
 			m_task->burpOutMutex.leave();

diff --git a/src/burp/burp.h b/src/burp/burp.h
@@ -946,7 +946,7 @@ class GblPool
 		: gbl_pool(ownPool ? MemoryPool::createPool(getDefaultMemoryPool()) : getDefaultMemoryPool())
 	{ }
 
-	~GblPool()
+	~GblPool() noexcept(false)
 	{
 		if (gbl_pool != getDefaultMemoryPool())
 			Firebird::MemoryPool::deletePool(gbl_pool);

diff --git a/src/common/SimilarToRegex.cpp b/src/common/SimilarToRegex.cpp
@@ -788,7 +788,7 @@ SimilarToRegex::SimilarToRegex(MemoryPool& pool, unsigned flags,
 	finalizer = pool.registerFinalizer(finalize, this);
 }
 
-SimilarToRegex::~SimilarToRegex()
+SimilarToRegex::~SimilarToRegex() noexcept(false)
 {
 	getPool().unregisterFinalizer(finalizer);
 }
@@ -860,7 +860,7 @@ SubstringSimilarRegex::SubstringSimilarRegex(MemoryPool& pool, unsigned flags,
 	finalizer = pool.registerFinalizer(finalize, this);
 }
 
-SubstringSimilarRegex::~SubstringSimilarRegex()
+SubstringSimilarRegex::~SubstringSimilarRegex() noexcept(false)
 {
 	getPool().unregisterFinalizer(finalizer);
 }

diff --git a/src/common/SimilarToRegex.h b/src/common/SimilarToRegex.h
@@ -49,7 +49,7 @@ class SimilarToRegex : public PermanentStorage
 public:
 	SimilarToRegex(MemoryPool& pool, unsigned flags,
 		const char* patternStr, unsigned patternLen, const char* escapeStr, unsigned escapeLen);
-	~SimilarToRegex();
+	~SimilarToRegex() noexcept(false);
 
 public:
 	static bool isSpecialChar(ULONG c)
@@ -96,7 +96,7 @@ class SubstringSimilarRegex : public PermanentStorage
 public:
 	SubstringSimilarRegex(MemoryPool& pool, unsigned flags,
 		const char* patternStr, unsigned patternLen, const char* escapeStr, unsigned escapeLen);
-	~SubstringSimilarRegex();
+	~SubstringSimilarRegex() noexcept(false);
 
 private:
 	static void finalize(SubstringSimilarRegex* self);

diff --git a/src/common/StatusArg.h b/src/common/StatusArg.h
@@ -85,7 +85,7 @@ class Base
 		virtual bool compare(const StatusVector& /*v*/) const noexcept { return false; }
 
 		ImplBase(ISC_STATUS k, ISC_STATUS c) noexcept : kind(k), code(c) { }
-		virtual ~ImplBase() { }
+		virtual ~ImplBase() noexcept(false) { }
 	};
 
 	Base(ISC_STATUS k, ISC_STATUS c);

diff --git a/src/common/StatusHolder.h b/src/common/StatusHolder.h
@@ -48,7 +48,7 @@ class DynamicVector : private SimpleStatusVector<S>
 		fb_utils::init_status(this->getBuffer(3));
 	}
 
-	~DynamicVector()
+	~DynamicVector() noexcept(false)
 	{
 		delete[] findDynamicStrings(this->getCount(), this->begin());
 	}

diff --git a/src/common/Task.cpp b/src/common/Task.cpp
@@ -170,7 +170,7 @@ bool Worker::waitFor(int timeout)
 
 /// class Coordinator
 
-Coordinator::~Coordinator()
+Coordinator::~Coordinator() noexcept(false)
 {
 	MutexLockGuard guard(m_mutex, FB_FUNCTION);
 

diff --git a/src/common/Task.h b/src/common/Task.h
@@ -49,7 +49,7 @@ class Task
 {
 public:
 	Task() {};
-	virtual ~Task() {};
+	virtual ~Task() noexcept(false) {};
 
 	// task item to handle
 	class WorkItem
@@ -59,7 +59,7 @@ class Task
 		  m_task(task)
 		{}
 
-		virtual ~WorkItem() {}
+		virtual ~WorkItem() noexcept(false) {}
 
 		Task*	m_task;
 	};
@@ -84,7 +84,7 @@ class Worker final
 	{
 	}
 
-	virtual ~Worker() {}
+	virtual ~Worker() noexcept(false) {}
 
 	void setTask(Task* task)
 	{
@@ -119,7 +119,7 @@ class Coordinator final
 		m_activeThreads(*m_pool)
 	{}
 
-	~Coordinator();
+	~Coordinator() noexcept(false);
 
 	void runSync(Task*);
 
@@ -165,7 +165,7 @@ class WorkerThread final
 public:
 	enum STATE {STARTING, IDLE, RUNNING, STOPPING, SHUTDOWN};
 
-	~WorkerThread()
+	~WorkerThread() noexcept(false)
 	{
 		shutdown(true);
 

diff --git a/src/common/classes/ClumpletReader.h b/src/common/classes/ClumpletReader.h
@@ -82,7 +82,7 @@ class ClumpletReader : protected AutoStorage
 	// Different versions of clumplets may have different kinds
 	ClumpletReader(const KindList* kl, const UCHAR* buffer, FB_SIZE_T buffLen, FPTR_VOID raise = NULL);
 	ClumpletReader(MemoryPool& pool, const KindList* kl, const UCHAR* buffer, FB_SIZE_T buffLen, FPTR_VOID raise = NULL);
-	virtual ~ClumpletReader() { }
+	virtual ~ClumpletReader() noexcept(false) { }
 
 	// Create a copy of reader
 	ClumpletReader(MemoryPool& pool, const ClumpletReader& from);

diff --git a/src/common/classes/File.h b/src/common/classes/File.h
@@ -34,7 +34,7 @@ namespace Firebird {
 class File
 {
 public:
-	virtual ~File() {}
+	virtual ~File() noexcept(false) {}
 
 	virtual FB_SIZE_T read(offset_t, void*, FB_SIZE_T) = 0;
 	virtual FB_SIZE_T write(offset_t, const void*, FB_SIZE_T) = 0;

diff --git a/src/common/classes/GenericMap.h b/src/common/classes/GenericMap.h
@@ -145,7 +145,7 @@ class GenericMap : public AutoStorage
 		: AutoStorage(a_pool), tree(&getPool()), mCount(0)
 	{ }
 
-	~GenericMap()
+	~GenericMap() noexcept(false)
 	{
 		clear();
 	}

diff --git a/src/common/classes/GetPlugins.h b/src/common/classes/GetPlugins.h
@@ -167,7 +167,7 @@ class GetPlugins
 		check(&status);
 	}
 
-	void removePlugin()
+	void removePlugin() noexcept
 	{
 		if (hasData())
 		{