Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named trace session (launched by fbsvcmgr with non-empty value for 'trc_name' parameter) can not be stopped using its name [CORE4876] #1943

Closed
firebird-issue-importer opened this issue Jul 15, 2015 · 8 comments

Comments

@firebird-issue-importer

Submitted by: @pavel-zotov

From the output of 'fbsvcmgr -?' one may see:
. . .
action_trace_stop:
trc_name [string value]
trc_id [numeric value]
. . .

But it seems that we can`t specify key-value pair like 'trc_name <my_trace_session>' in order to STOP previously launched trace.
Following is what I did in cmd.exe having prepared trivial config for trace ('tmp_trace.cfg'):

Step #⁠1

C:\...> start fbsvcmgr localhost:service_mgr user SYSDBA password masterkey action_trace_start trc_cfg .\tmp_trace.cfg trc_name my_favorite_trace_ssn_01
// OK, new window will be opened with launched trace session

Step #⁠2
C:\...> fbsvcmgr localhost:service_mgr user SYSDBA password masterkey action_trace_list
/*
Output:
Session ID: 2
name: my_favorite_trace_ssn_01
user:
date: 2015-07-15 15:28:52
flags: active, trace
*/

Step #⁠3
C:\...> fbsvcmgr localhost:service_mgr user SYSDBA password masterkey action_trace_stop my_favorite_trace_ssn_01

Error: parameter "NAME" is incompatible with action "STOP"

So, either this option should be excluded from output of fbsvcmgr (and this will be really BAD!) or `action_trace_stop` should be pretty clever to stop trace sessions by their names (and I'm strongly voting for 2nd case :)).

Commits: d511444 e1f3ac4 FirebirdSQL/fbt-repository@0daa2e3 FirebirdSQL/fbt-repository@e749070

====== Test Details ======

Implementing has no sense: there is no more such option in fbsvcmgr as " trc_name [string value] "

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jul 15, 2015

Commented by: @hvlad

Stop trace session by name was never supported nor promised.
There is no bug.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jul 15, 2015

Modified by: @hvlad

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Won't Fix [ 2 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jul 15, 2015

Commented by: @hvlad

Sorry, i don't saw error in fbsvcmgr help screen.
Re-opened to fix it.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jul 15, 2015

Modified by: @hvlad

status: Resolved [ 5 ] => Reopened [ 4 ]

assignee: Vlad Khorsun [ hvlad ]

resolution: Won't Fix [ 2 ] =>

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jul 15, 2015

Modified by: @hvlad

Version: 3.0 Beta 2 [ 10586 ]

Version: 2.5.4 [ 10585 ]

Version: 2.5.3 Update 1 [ 10650 ]

Version: 3.0 Beta 1 [ 10332 ]

Version: 2.5.3 [ 10461 ]

Version: 3.0 Alpha 2 [ 10560 ]

Version: 3.0 Alpha 1 [ 10331 ]

Version: 2.5.2 Update 1 [ 10521 ]

Version: 2.5.2 [ 10450 ]

Version: 2.5.1 [ 10333 ]

Version: 2.5.0 [ 10221 ]

Fix Version: 3.0 RC 1 [ 10584 ]

Fix Version: 2.5.5 [ 10670 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jul 15, 2015

Modified by: @hvlad

status: Reopened [ 4 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jul 27, 2015

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Cannot be tested

Test Details: Implementing has no sense: there is no more such option in fbsvcmgr as " trc_name [string value] "

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jul 27, 2015

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment