Write note into log when automatic sweep is started [CORE2668]

[firebird-automations]

Submitted by: @aafemt

Relate to CORE3978

Votes: 9

It would be nice to have in log a record about automatic sweep start. This way DBA can notice problems (or no problems) with transaction management. Currently newbies blame sweep in all slowdowns and unnecessary tune autosweep interval.

Commits: 9124f5e 05dc7aa

[firebird-automations]

Commented by: Sean Leyne (seanleyne)

Nice request! I would suggest one change.

Log all sweep starts, not just those triggered by the sweep interval, but also those triggered via GFIX.

It is possible for an admin to not know about a sweep which has been scheduled by another admin, or they could have forgotten themselves.

[firebird-automations]

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

[firebird-automations]

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Open [ 1 ]

Target: 3.0.0 [ 10048 ]

[firebird-automations]

Commented by: Christian Masberg (cubism)

Very usefull!
Otherwise I don't know of a way of identifying the sweep interval, because it is not written into the server log.

[firebird-automations]

Commented by: Sean Leyne (seanleyne)

One additional item, also log when the sweep ends/stops.

[firebird-automations]

Modified by: @dyemanov

assignee: Alexander Peshkov [ alexpeshkoff ] => Vlad Khorsun [ hvlad ]

Fix Version: 2.5.2 [ 10450 ]

Fix Version: 3.0 Alpha 1 [ 10331 ]

[firebird-automations]

Commented by: @hvlad

firebird log will contain following records about sweep :

a) when sweep started :

 Sweep is started by <user name\>
 Database <database name\> 
 OIT <n\>, OAT <n\>, OST <n\>, Next <n\>

b) when sweep finished successfully (no errors was thrown) :

 Sweep is finished
 Database <database name\> 
 OIT <n\>, OAT <n\>, OST <n\>, Next <n\>

c) when some exception breaks the sweep execution :
Error during sweep:
<error details>

[firebird-automations]

Modified by: @hvlad

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

[firebird-automations]

Modified by: @dyemanov

Link: This issue relate to CORE3978 [ CORE3978 ]

[firebird-automations]

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

[firebird-automations]

Modified by: @pavel-zotov

QA Status: No test

[firebird-automations]

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: No test => Done successfully