-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Placing comment (single-lined or multi-lined) between final END
of creating SP code and terminal character (^) produces compiling error when tool uses old API [CORE4890]
#5184
Comments
Commented by: @asfernandes What about test this connecting from 2.5 isql? If it works, it's going to be an IBE bug (which seems to be IMO). |
Commented by: @aafemt What can you see in trace? |
Commented by: @pavel-zotov I works OK when I run this script using following: 1) connect from isql 2.5 to database 2.5: ISQL Version: WI-V2.5.5.26916 Firebird 2.5 2) connect from isql 3.0 to database 2.5: 3) connect from isql 2.5 to database 3.0: ISQL Version: WI-V2.5.5.26916 Firebird 2.5 4) connect from isql 3.0 to database 3.0: ISQL Version: WI-V3.0.0.31948 Firebird 3.0 Release Candidate 1 I also works OK when I run this script in IBE and use fbclient 2.5 and database 2.5 |
Commented by: @pavel-zotov > What can you see in trace? When I run trace with following config:database time_threshold = 0 log_connections = true log_context = true log_statement_prepare = true log_statement_free = true log_statement_finish = true log_procedure_finish = true print_plan = true max_sql_length = 8192
|
Commented by: @asfernandes Their problem. |
Commented by: @dyemanov Error "Missing close comment for" is raised by Firebird, see Tokens::parse(). The new pre-parser is used to handle only CREATE DATABASE statements but before that it parses the whole statement and supposedly does not treat inline comments properly. |
Modified by: @dyemanovVersion: 3.0 Beta 2 [ 10586 ] assignee: Alexander Peshkov [ alexpeshkoff ] Version: 3.0 RC 1 [ 10584 ] => |
Modified by: @AlexPeshkoffstatus: Open [ 1 ] => Resolved [ 5 ] resolution: Fixed [ 1 ] Fix Version: 3.0 RC 1 [ 10584 ] |
Modified by: @pavel-zotovstatus: Resolved [ 5 ] => Resolved [ 5 ] QA Status: No test => Deferred Test Details: Waiting for reply on issue in CORE4882, 25/Aug/15 06:39 PM |
Modified by: @pcisarstatus: Resolved [ 5 ] => Closed [ 6 ] |
Submitted by: @pavel-zotov
Following script (note that after `end` and before `^` there are comments):
set term ^;
create or alter procedure sp_test1 as
begin
exit;
end -- blah-blah-blah'
^
create or alter procedure sp_test2 as
begin
exit;
end /* blah-blah-blah */
^
-- runs OK in ISQL but produces strange exception in IBExpert when connecting to WI-V6.3.0.31948
Error messages in IBExpert:
Unsuccessful execution caused by system error that does not preclude successful execution of subsequent statements.
Parse to tokens error.
Missing close comment for --.
= and =
Unsuccessful execution caused by system error that does not preclude successful execution of subsequent statements.
Firebird::string - pos out of range.
(for the 1st and 2nd DDL accordingly).
I thought that this is bug in IBE but *no* such errors in this IDE when doing that on WI-V6.3.5.26916.
As I was explained in russian FB conference ( http://www.sql.ru/forum/actualutils.aspx?action=gotomsg&tid=1168067&msg=17946430 ), IBE uses some old kind of API rather than ISQL.
So, it seems that this is bug somewhere in FB-parser.
Commits: db0c84f FirebirdSQL/fbt-repository@3849ac9
====== Test Details ======
Waiting for reply on issue in CORE4882, 25/Aug/15 06:39 PM
The text was updated successfully, but these errors were encountered: