Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetching from a scrollable cursor may overwrite user-specified buffer and corrupt memory #7056

Closed
dyemanov opened this issue Dec 1, 2021 · 3 comments
Closed

Fetching from a scrollable cursor may overwrite user-specified buffer and corrupt memory #7056

dyemanov opened this issue Dec 1, 2021 · 3 comments
Assignees
@dyemanov
Labels
affect-version: 3.0.8 affect-version: 4.0.0 affect-version: 5.0 Initial component: engine fix-version: 3.0.9 fix-version: 4.0.1 fix-version: 5.0 Beta 1 qa: deferred type: bug

Comments

@dyemanov
Copy link
Member

dyemanov commented Dec 1, 2021

Every fetch from a scrollable cursor returns 2-8 bytes longer message than the client expects. Sometimes this may be harmless, but sometimes it may corrupt application memory and thus cause various crashes.
@dyemanov dyemanov self-assigned this Dec 1, 2021
dyemanov added a commit that referenced this issue Dec 6, 2021
@dyemanov
Fixed #7056 (Fetching from a scrollable cursor may overwrite user-spe…
2196854 
…cified buffer and corrupt memory) and #7057 (Client-side positioned updates work wrongly with scrollable cursors) with a single shot
@pavel-zotov
Copy link

Test will be added after migration to pytest/firebird-driver framework.

@ilya071294
Copy link
Collaborator

Will FB3 be fixed?

@dyemanov
Copy link
Member Author

dyemanov commented Feb 5, 2022

It requires more changes for backporting, thus was postponed. But if there's a demand to have this fix in v3, I will do it during this weekend.

dyemanov added a commit that referenced this issue Feb 8, 2022
@dyemanov
Fixed #7056 (Fetching from a scrollable cursor may overwrite user-spe…
c4ad5af 
…cified buffer and corrupt memory) and #7057 (Client-side positioned updates work wrongly with scrollable cursors) with a single shot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dyemanov dyemanov

Labels
affect-version: 3.0.8 affect-version: 4.0.0 affect-version: 5.0 Initial component: engine fix-version: 3.0.9 fix-version: 4.0.1 fix-version: 5.0 Beta 1 qa: deferred type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dyemanov @pavel-zotov @ilya071294